-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Provide --baseline
driver command argument that accepts SARIF log baseline file.
#2370
Comments
This was referenced Jun 30, 2021
Will take a look at this issue. |
This was
linked to
pull requests
Jul 15, 2021
With the PR's above, we added the basic baseline functionality. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The rough behavior should look like this:
--baseline
is loaded.updated
,new
,unchanged
, orabsent
--inline
switch is passed, the baseline log location is overwritten, otherwise a new log is generated.absent
in the baseline should be flushed before result matching. And so the output for any newly generated file will only includeabsent
results that reflect issues that have been between the baseline run (where they existed) and the new run (where they do not).As part of this change, we should be sure to update our input argument validation.
--baseline
+--inline
is sufficient for processing, for example, but--baseline
without--inline
(and with no output log file argument specified) is not legal. Etc.Note that after we complete this first work, there may be some more useful work we could do. For example, users could filter the newly generated file to some subset or arbitrary set of baseline states, e.g., 'persist newly introduced issues only'. We could consider changes to result codes or introduce other breaking mechanisms ('break on any newly introduced issue').
The change described here is foundational and stands as useful on its own, however.
The text was updated successfully, but these errors were encountered: