Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SARIF Multitool] Allow running as tool on .NET 6.0 runtime (.NET Core 3.1 support ended in December 2022) #2511

Open
KalleOlaviNiemitalo opened this issue Jul 26, 2022 · 3 comments

Comments

@KalleOlaviNiemitalo
Copy link

The Sarif.Multitool package targets netcoreapp3.1 and net472. I tried to use it as a .NET tool on a computer that had Windows and .NET SDK 6.0.302 but no .NET Core 3.1 runtime. dotnet tool install installed it okay, but dotnet tool run sarif failed to launch and told me it needs the .NET Core 3.1 runtime. Because Microsoft will stop supporting .NET Core 3.1 on December 13, 2022, I'd like to start uninstalling its runtime from computers.

Could you change the Sarif.Multitool package so that it will work on .NET 6.0 without needing the .NET Core 3.1 runtime? Perhaps by multitargeting, or perhaps by configuring roll-forward.

(The Sarif.Multitool.Library package has no such problem, because it targets netstandard2.1 and net472.)

@KalleOlaviNiemitalo
Copy link
Author

I can apparently override this by setting DOTNET_ROLL_FORWARD=Major in the environment. That feels a bit suspicious though, because if the tool started any child processes, they too would inherit the environment variable.

@KalleOlaviNiemitalo
Copy link
Author

dotnet/sdk#26417 (comment) seems to recommend that .NET tool packages allow major version roll-forward.

@KalleOlaviNiemitalo
Copy link
Author

.NET Core 3.1 support has now ended.

@KalleOlaviNiemitalo KalleOlaviNiemitalo changed the title [SARIF Multitool] Allow running as tool on .NET 6.0 runtime (.NET Core 3.1 support ends in December 2022) [SARIF Multitool] Allow running as tool on .NET 6.0 runtime (.NET Core 3.1 support ended in December 2022) Sep 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant