Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support 'IncompatibleRuleIds' in the infrastructure #2591

Closed
yongyan-gh opened this issue Dec 13, 2022 · 1 comment
Closed

Support 'IncompatibleRuleIds' in the infrastructure #2591

yongyan-gh opened this issue Dec 13, 2022 · 1 comment

Comments

@yongyan-gh
Copy link
Collaborator

Please see more details in #2580

Rules should be able to declare an IncompatibleRuleIds set or something similar, All the rule does is to publish this data.

Then we update the analysis engine, which, when instantiating skimmers, makes sure that no new enabled skimmers have a rule id that conflicts with the set of loaded skimmers so far. The analysis engine could raise an error-level configuration notification and exit.

This approach would require users to properly configure analysis to account for the configuration problem. I think everything would drop in pretty cleanly by doing this, we need a low-level update to rules metadata and a simple update to the default skimmer loading behavior.

@shaopeng-gh
Copy link
Collaborator

Closing the issue with the feature Yong implemented.
#2597

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants