You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
<value>{0}: The 'artifactLocation' object on this 'physicalLocation' object does not provide a 'uri' object. This property is required by the {1} service.</value>
<value>Provide the 'region' property, along with the appropriate region properties. This property is required by the GitHub Advanced Security service.
Provide the 'artifactLocation' property. This property is required by the GitHub Advanced Security service.</value>
</data>
Are quite different. GH1017 logic seems to be checking that if artifactLocation is included in the SARIF report output then its uri property must be set. This makes sense as a rule. But the full description says artifactLocation should be included in the output, and region as well, but these aren't the checks that are actually being executed by this rule, so the output is quite confusing.
Possibly related to #2821 however artifactLocation.uri is being set there so that doesn't seem to be the root cause for that issue either.
The text was updated successfully, but these errors were encountered:
This log output for GH1017:
sarif-sdk/src/Sarif.Multitool.Library/Rules/RuleResources.resx
Lines 549 to 551 in 29d527f
And this full description for the same rule:
sarif-sdk/src/Sarif.Multitool.Library/Rules/RuleResources.resx
Lines 648 to 652 in 29d527f
Are quite different. GH1017 logic seems to be checking that if
artifactLocation
is included in the SARIF report output then itsuri
property must be set. This makes sense as a rule. But the full description saysartifactLocation
should be included in the output, and region as well, but these aren't the checks that are actually being executed by this rule, so the output is quite confusing.Possibly related to #2821 however
artifactLocation.uri
is being set there so that doesn't seem to be the root cause for that issue either.The text was updated successfully, but these errors were encountered: