Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Mount Removal] Move repo registration from mount verb to clone verb #111

Closed
wilbaker opened this issue Sep 16, 2019 · 1 comment · Fixed by #216
Closed

[Mount Removal] Move repo registration from mount verb to clone verb #111

wilbaker opened this issue Sep 16, 2019 · 1 comment · Fixed by #216
Assignees
@wilbaker
Labels
disk-layout Issues that impact the disk layout used by Scalar
Milestone
MVP

Comments

@wilbaker
Copy link
Member

wilbaker commented Sep 16, 2019 •
edited
Loading

Repo registration (with Scalar.Service) should happen during scalar clone rather than mount.

Additionally, the clone verb itself should update the registration file (or each clone should create its own file) and Scalar.Service should read the file(s) to discover which repos have been registered.

Additionally:

  • Scalar.Service should also remove repos when it finds they're no longer on disk.
  • There should be a verb for manually registering/unregistering repos
  • Functional tests should not register when cloning or they should register in a test location that does not impact the installed Scalar.Service
@wilbaker wilbaker changed the title Move repo registration from mount verb to clone verb [Scalar.Mount Removal] Move repo registration from mount verb to clone verb Sep 16, 2019
@wilbaker wilbaker changed the title [Scalar.Mount Removal] Move repo registration from mount verb to clone verb [Mount Removal] Move repo registration from mount verb to clone verb Sep 16, 2019
@wilbaker wilbaker mentioned this issue Sep 16, 2019
Closed
@wilbaker wilbaker added the disk-layout Issues that impact the disk layout used by Scalar label Oct 2, 2019
@derrickstolee derrickstolee added this to the MVP milestone Oct 4, 2019
This was referenced Oct 21, 2019
Closed
Merged
This was referenced Oct 29, 2019
Merged
Merged
@wilbaker
Copy link
Member Author

wilbaker commented Nov 4, 2019

I'm splitting these parts out into their own issues:

  • There should be a verb for manually registering/unregistering repos
  • Functional tests should not register when cloning or they should register in a test location that does not impact the installed Scalar.Service

This was referenced Nov 4, 2019
Closed
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wilbaker wilbaker

Labels
disk-layout Issues that impact the disk layout used by Scalar
Projects
None yet
Milestone
MVP
Development

Successfully merging a pull request may close this issue.

RepoRegistry: refactor format and access directly from verbs wilbaker/gsd
2 participants
@derrickstolee @wilbaker