Using new Feature Syntax #161
Conversation
|
Hi @ross-p-smith, do you plan to do something else with this PR? because I see TODO in your PR description, so not sure if this PR is ready for review or not. |
|
@ross-p-smith follow-up... :) |
|
Hi @DariuszPorowski - sorry this slipped me by. I'll open this back up tomorrow. But the question is why the original version of your DevContainer has both Docker in Docker and Docker-From-Docker. Normally you would pick one. Would you know the answer? |
|
@ross-p-smith I think that was copy-paste case ;) I think we can get rid of dockerfile completely and move to devcontaiver v2 only |
ross-p-smith
force-pushed
the
ross/versions
branch
from
225f963
to
c98c22c
Compare
|
@DariuszPorowski - can you confirm if I am going down the right track - if so - I just have to finish devcontainer.TODO which is just copying the tflint.zip file (which is 10 minutes work) Is this the basic premise of what you are after? |
|
@ross-p-smith I think we are on the perfect track! thank you :) |
This PR uses the new Feature syntax and remove the dockerfile
I've also updated the syntax for settings and extensions as these have changed.
Fixes #160