[Bug] [C#] Multiple tools calls of the same function in the same run is not handled correctly.

[singhk97]

teams-ai/dotnet/packages/Microsoft.TeamsAI/Microsoft.TeamsAI/AI/Planners/AssistantsPlanner.cs

Lines 212 to 222 in 5fda47e

	// Currently `RequiredAction` is only for a function tool call
	// TODO: Potential bug if assistant predicts same tool twice.
	toolMap[requiredAction.FunctionName] = requiredAction.ToolCallId;
	plan.Commands.Add(new PredictedDoCommand
	(
	requiredAction.FunctionName,
	JsonSerializer.Deserialize<Dictionary<string, object?>>(requiredAction.FunctionArguments)
	?? new Dictionary<string, object?>()
	));
	}
	state.SubmitToolMap = toolMap;

Problem 1

• In line 214, toolMap key takes the function name, which means if two separate tool calls invoke the same function, one of them would be overriden.

Solution

• Set the tool call id (unique) as the key and the function name as the value.

teams-ai/dotnet/packages/Microsoft.TeamsAI/Microsoft.TeamsAI/AI/AI.cs

Lines 267 to 285 in 5fda47e

	if (_actions.ContainsAction(doCommand.Action))
	{
	DoCommandActionData<TState> data = new()
	{
	PredictedDoCommand = doCommand,
	Handler = _actions[doCommand.Action].Handler
	};
	// Call action handler
	output = await this._actions[AIConstants.DoCommandActionName]
	.Handler
	.PerformActionAsync(turnContext, turnState, data, doCommand.Action, cancellationToken);
	shouldLoop = output.Length > 0;
	if (turnState.Temp != null)
	{
	turnState.Temp.ActionOutputs[doCommand.Action] = output;
	}
	}

Problem 2

• Suppose problem 1 is fixed. In line 283, the ActionOutputs also runs in the same issue where the action output of the first action call is overriden by the second.

Possible Solutions

• Update the key of ActionOutputs to be unique.
• Set the value of ActionOutputs to be an array of strings.

[singhk97]

This has been fixed in JS/PY when implementing tools support in the ActionPlanner