[C#] fix: Add strong name signing to dlls (#2372)

KirillOsenkov · singhk97 · web-flow · commit 6473c84d4bb9 · 2025-04-03T12:22:49.000-07:00
#minor

Add strong-name signing

Co-authored-by: Kavin &lt;115390646+singhk97@users.noreply.github.com&gt;
diff --git a/dotnet/packages/Microsoft.TeamsAI/Directory.Build.props b/dotnet/packages/Microsoft.TeamsAI/Directory.Build.props
@@ -0,0 +1,8 @@
+<Project>
+
+  <PropertyGroup>
+    <SignAssembly>True</SignAssembly>
+    <AssemblyOriginatorKeyFile>$([MSBuild]::GetPathOfFileAbove('key.snk'))</AssemblyOriginatorKeyFile>
+  </PropertyGroup>
+
+</Project>
diff --git a/dotnet/packages/Microsoft.TeamsAI/Microsoft.TeamsAI/AI/Action/ActionCollection.cs b/dotnet/packages/Microsoft.TeamsAI/Microsoft.TeamsAI/AI/Action/ActionCollection.cs
@@ -1,8 +1,6 @@
 ﻿using Microsoft.Teams.AI.State;
 using System.Runtime.CompilerServices;
 
-// For Unit Testing
-[assembly: InternalsVisibleTo("Microsoft.Teams.AI.Tests")]
 namespace Microsoft.Teams.AI.AI.Action
 {
     internal class ActionCollection<TState> : IActionCollection<TState> where TState : TurnState
diff --git a/dotnet/packages/Microsoft.TeamsAI/Microsoft.TeamsAI/AI/Models/OpenAIModel.cs b/dotnet/packages/Microsoft.TeamsAI/Microsoft.TeamsAI/AI/Models/OpenAIModel.cs
@@ -23,7 +23,6 @@
 using System.Runtime.CompilerServices;
 using Microsoft.Extensions.Options;
 
-[assembly: InternalsVisibleTo("Microsoft.Teams.AI.Tests")]
 #pragma warning disable AOAI001 // Type is for evaluation purposes only and is subject to change or removal in future updates. Suppress this diagnostic to proceed.
 namespace Microsoft.Teams.AI.AI.Models
 {
diff --git a/dotnet/packages/Microsoft.TeamsAI/Microsoft.TeamsAI/AI/OpenAI/OpenAIClient.cs b/dotnet/packages/Microsoft.TeamsAI/Microsoft.TeamsAI/AI/OpenAI/OpenAIClient.cs
@@ -12,8 +12,6 @@
 using Microsoft.Teams.AI.Exceptions;
 using Microsoft.Teams.AI.Utilities;
 
-// For Unit Tests - so the Moq framework can mock internal classes
-[assembly: InternalsVisibleTo("DynamicProxyGenAssembly2")]
 namespace Microsoft.Teams.AI.AI.OpenAI
 {
     /// <summary>
diff --git a/dotnet/packages/Microsoft.TeamsAI/Microsoft.TeamsAI/AI/Planners/AssistantsPlanner.cs b/dotnet/packages/Microsoft.TeamsAI/Microsoft.TeamsAI/AI/Planners/AssistantsPlanner.cs
@@ -18,7 +18,6 @@
 #pragma warning disable OPENAI001
 // Assistants API is currently in beta and is subject to change.
 #pragma warning disable IDE0130 // Namespace does not match folder structure
-[assembly: InternalsVisibleTo("Microsoft.Teams.AI.Tests")]
 namespace Microsoft.Teams.AI.AI.Planners.Experimental
 #pragma warning restore IDE0130 // Namespace does not match folder structure
 {
diff --git a/dotnet/packages/Microsoft.TeamsAI/Microsoft.TeamsAI/Application/Authentication/OAuthAuthentication.cs b/dotnet/packages/Microsoft.TeamsAI/Microsoft.TeamsAI/Application/Authentication/OAuthAuthentication.cs
@@ -4,7 +4,6 @@
 using Microsoft.Teams.AI.State;
 using System.Runtime.CompilerServices;
 
-[assembly: InternalsVisibleTo("Microsoft.Teams.AI.Tests")]
 namespace Microsoft.Teams.AI
 {
     /// <summary>
diff --git a/dotnet/packages/Microsoft.TeamsAI/Microsoft.TeamsAI/Microsoft.Teams.AI.csproj b/dotnet/packages/Microsoft.TeamsAI/Microsoft.TeamsAI/Microsoft.Teams.AI.csproj
@@ -1,4 +1,4 @@
-<Project Sdk="Microsoft.NET.Sdk">
+﻿<Project Sdk="Microsoft.NET.Sdk">
 
   <PropertyGroup>
 	  <TargetFramework>netstandard2.0</TargetFramework>
@@ -34,6 +34,11 @@
     <IncludeSymbols>true</IncludeSymbols>
   </PropertyGroup>
 
+  <ItemGroup>
+    <InternalsVisibleTo Include="Microsoft.Teams.AI.Tests" PublicKey="0024000004800000940000000602000000240000525341310004000001000100b1824ba3bb2e1e9ab1286076ceb0716adc32b46315c6bd106f45928aaa56d50d6cc4c8df7da3715bda9acda3652d964b2b4343a80121b35a815b3b462ddf18dbd4cb0af9b60760f40f85cd3a891a08856a8391b1e34fc09df50eb71b182a25e65476249a826f83445ed47b14747c01b9db2f3c7cd6909f2b06f5c7d15a108fde" />
+    <InternalsVisibleTo Include="DynamicProxyGenAssembly2" PublicKey="0024000004800000940000000602000000240000525341310004000001000100c547cac37abd99c8db225ef2f6c8a3602f3b3606cc9891605d02baa56104f4cfc0734aa39b93bf7852f7d9266654753cc297e7d2edfe0bac1cdcf9f717241550e0a7b191195b7667bb4f64bcb8e2121380fd1d9d46ad2d92d2d15605093924cceaf74c4861eff62abf69b9291ed0a340e113be11e6a7d3113e92484cf7045cc7" />
+  </ItemGroup>
+
   <ItemGroup>
     <PackageReference Include="AdaptiveCards" Version="3.1.0" />
     <PackageReference Include="Azure.AI.ContentSafety" Version="1.0.0" />
diff --git a/dotnet/packages/Microsoft.TeamsAI/Microsoft.TeamsAI/State/TurnState.cs b/dotnet/packages/Microsoft.TeamsAI/Microsoft.TeamsAI/State/TurnState.cs
@@ -4,7 +4,6 @@
 using Microsoft.Teams.AI.Utilities;
 using System.Runtime.CompilerServices;
 
-[assembly: InternalsVisibleTo("Microsoft.Teams.AI.Tests")]
 namespace Microsoft.Teams.AI.State
 {
     /// <summary>
diff --git a/dotnet/packages/Microsoft.TeamsAI/Microsoft.TeamsAI/State/TurnStateEntry.cs b/dotnet/packages/Microsoft.TeamsAI/Microsoft.TeamsAI/State/TurnStateEntry.cs
@@ -2,7 +2,6 @@
 using System.Runtime.CompilerServices;
 using System.Text.Json;
 
-[assembly: InternalsVisibleTo("Microsoft.Teams.AI.Tests")]
 namespace Microsoft.Teams.AI.State
 {
     /// <summary>
diff --git a/dotnet/packages/Microsoft.TeamsAI/Microsoft.TeamsAI/Utilities/DefaultHttpClient.cs b/dotnet/packages/Microsoft.TeamsAI/Microsoft.TeamsAI/Utilities/DefaultHttpClient.cs
@@ -1,7 +1,5 @@
 ﻿using System.Runtime.CompilerServices;
 
-// For Unit Test
-[assembly: InternalsVisibleTo("Microsoft.Teams.AI.Tests")]
 namespace Microsoft.Teams.AI.Utilities
 {
     /// <summary>
diff --git a/dotnet/packages/key.snk b/dotnet/packages/key.snk
diff --git a/dotnet/packages/key.txt b/dotnet/packages/key.txt
@@ -0,0 +1,13 @@
+﻿Read more about strong name signing here:
+https://aka.ms/snexe
+
+// extract public key from key pair:
+sn –p key.snk public.snk
+
+// view public key:
+sn -tp public.snk
+
+Public key (hash algorithm: sha1):
+0024000004800000940000000602000000240000525341310004000001000100b1824ba3bb2e1e9ab1286076ceb0716adc32b46315c6bd106f45928aaa56d50d6cc4c8df7da3715bda9acda3652d964b2b4343a80121b35a815b3b462ddf18dbd4cb0af9b60760f40f85cd3a891a08856a8391b1e34fc09df50eb71b182a25e65476249a826f83445ed47b14747c01b9db2f3c7cd6909f2b06f5c7d15a108fde
+
+Public key token is 53cbbf437edd3fb2

Original file line number	Diff line number	Diff line change
`@@ -1,8 +1,6 @@`
`1`	`1`	`using Microsoft.Teams.AI.State;`
`2`	`2`	`using System.Runtime.CompilerServices;`
`3`	`3`
`4`		`-// For Unit Testing`
`5`		`-[assembly: InternalsVisibleTo("Microsoft.Teams.AI.Tests")]`
`6`	`4`	`namespace Microsoft.Teams.AI.AI.Action`
`7`	`5`	`{`
`8`	`6`	`internal class ActionCollection<TState> : IActionCollection<TState> where TState : TurnState`
Original file line number	Diff line number	Diff line change
`@@ -23,7 +23,6 @@`
`23`	`23`	`using System.Runtime.CompilerServices;`
`24`	`24`	`using Microsoft.Extensions.Options;`
`25`	`25`
`26`		`-[assembly: InternalsVisibleTo("Microsoft.Teams.AI.Tests")]`
`27`	`26`	`#pragma warning disable AOAI001 // Type is for evaluation purposes only and is subject to change or removal in future updates. Suppress this diagnostic to proceed.`
`28`	`27`	`namespace Microsoft.Teams.AI.AI.Models`
`29`	`28`	`{`
Original file line number	Diff line number	Diff line change
`@@ -12,8 +12,6 @@`
`12`	`12`	`using Microsoft.Teams.AI.Exceptions;`
`13`	`13`	`using Microsoft.Teams.AI.Utilities;`
`14`	`14`
`15`		`-// For Unit Tests - so the Moq framework can mock internal classes`
`16`		`-[assembly: InternalsVisibleTo("DynamicProxyGenAssembly2")]`
`17`	`15`	`namespace Microsoft.Teams.AI.AI.OpenAI`
`18`	`16`	`{`
`19`	`17`	`/// <summary>`
Original file line number	Diff line number	Diff line change
`@@ -18,7 +18,6 @@`
`18`	`18`	`#pragma warning disable OPENAI001`
`19`	`19`	`// Assistants API is currently in beta and is subject to change.`
`20`	`20`	`#pragma warning disable IDE0130 // Namespace does not match folder structure`
`21`		`-[assembly: InternalsVisibleTo("Microsoft.Teams.AI.Tests")]`
`22`	`21`	`namespace Microsoft.Teams.AI.AI.Planners.Experimental`
`23`	`22`	`#pragma warning restore IDE0130 // Namespace does not match folder structure`
`24`	`23`	`{`
Original file line number	Diff line number	Diff line change
`@@ -4,7 +4,6 @@`
`4`	`4`	`using Microsoft.Teams.AI.State;`
`5`	`5`	`using System.Runtime.CompilerServices;`
`6`	`6`
`7`		`-[assembly: InternalsVisibleTo("Microsoft.Teams.AI.Tests")]`
`8`	`7`	`namespace Microsoft.Teams.AI`
`9`	`8`	`{`
`10`	`9`	`/// <summary>`
Original file line number	Diff line number	Diff line change
`@@ -2,7 +2,6 @@`
`2`	`2`	`using System.Runtime.CompilerServices;`
`3`	`3`	`using System.Text.Json;`
`4`	`4`
`5`		`-[assembly: InternalsVisibleTo("Microsoft.Teams.AI.Tests")]`
`6`	`5`	`namespace Microsoft.Teams.AI.State`
`7`	`6`	`{`
`8`	`7`	`/// <summary>`
Original file line number	Diff line number	Diff line change
`@@ -1,7 +1,5 @@`
`1`	`1`	`using System.Runtime.CompilerServices;`
`2`	`2`
`3`		`-// For Unit Test`
`4`		`-[assembly: InternalsVisibleTo("Microsoft.Teams.AI.Tests")]`
`5`	`3`	`namespace Microsoft.Teams.AI.Utilities`
`6`	`4`	`{`
`7`	`5`	`/// <summary>`