Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Under the solarized light theme, the display of the ls command is incorrect #10027

Closed
LuoZhongYao opened this issue May 4, 2021 · 2 comments
Closed
Labels
Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing.

Comments

@LuoZhongYao
Copy link

Windows Terminal version (or Windows build number)

10.0.19042.928

Other Software

ls (GNU coreutils) 8.32 (inside wsl)

Steps to reproduce

Use solarized light theme, open wsl and run ls command

Expected Behavior

ls command displays accurate colors
img

Actual Behavior

The ls command displays the wrong color
img

@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels May 4, 2021
@zadjii-msft
Copy link
Member

DAYS SINCE I'VE REGRETTED SHIPPING SOLARIZED: 15 0

Solarized is an unfortunately bad theme for commandline applications, if you follow it exactly as authored. The majority of the bright colors are all basically just grayscale, which IMO is useless in a color scheme:

image

I bet whatever terminal you're using in the "expected" screenshot has a modified version of solarized that's actually useful. We decided to follow the standard exactly as is, to much pain.

I think this is broadly /dup #6997

@ghost
Copy link

ghost commented May 4, 2021

Hi! We've identified this issue as a duplicate of another one that already exists on this Issue Tracker. This specific instance is being closed in favor of tracking the concern over on the referenced thread. Thanks for your report!

@ghost ghost closed this as completed May 4, 2021
@ghost ghost added Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing. and removed Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels May 4, 2021
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing.
Projects
None yet
Development

No branches or pull requests

2 participants