Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configurable Quake Mode window width, to accommodate ultra-wide resolutions #10180

Closed
riverar opened this issue May 25, 2021 · 9 comments
Closed
Labels
Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. Needs-Attention The core contributors need to come back around and look at this ASAP. Needs-Tag-Fix Doesn't match tag requirements Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Product-Terminal The new Windows Terminal.

Comments

@riverar
Copy link

riverar commented May 25, 2021

Summary

Quake Mode (#9274) provides, well, a Quake-like console that appears on use of a global hotkey. This console window opens at the maximum width of the active workspace, however, creating usability issues on ultra-wide displays.

Consider a user sitting at the center of this screenshot:
image

Proposal

Allow for a user-configurable width, preferably in relative sizing units (to accommodate resolution changes).

Example:

{
  // ...
  "quakeMode.window.width": "50%"
}
@riverar riverar added the Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. label May 25, 2021
@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels May 25, 2021
@riverar riverar changed the title mini-Quake mode for ultra-wide monitor users Configurable Quake Mode window width, to accommodate ultra-wide resolutions May 25, 2021
@zadjii-msft
Copy link
Member

So, IMO quake mode is more of an "easter egg" mode than anything else. If you want exactly the behavior of quake mode, then bind quakeMode. If you want some other behavior, then feel free to bind something else. I personally just use

{ "keys": "win+`", "command": { "action": "globalSummon", "monitor": "any" } },

which just activates the window where it is, without all the other "quake mode" hijinks. So you could bind that, and the window would still obey the normal initialRows, initialCols, etc. Does that seem like a reasonable solution?

(we've also got #9992 tracking "allow users to set settings per-window name", which would let users change the initialPosition, initialRows, etc for the _quake window).

@DHowett
Copy link
Member

DHowett commented May 25, 2021

LOL. Yeah, that makes sense.

@zadjii-msft, perhaps we can roll this into "per-window launch properties" where a launch size/initial width for _quake specifies magic?

@zadjii-msft zadjii-msft added Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something Product-Terminal The new Windows Terminal. labels May 25, 2021
@riverar
Copy link
Author

riverar commented May 25, 2021

This mode was communicated as such at Build 2021:

Quake Mode allows users to quickly open a new terminal window from anywhere in Windows with a simple keyboard shortcut.

I wasn't aware of the global summon action so I'll try that out. I'll be looking for positioning configuration of that window as well.

If the team consensus is that Quake Mode was designed to be a gimmick and not a useful feature per Build comms, then feel free to close this issue. I'm okay with that.

@ghost ghost added Needs-Attention The core contributors need to come back around and look at this ASAP. and removed Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something labels May 25, 2021
@zadjii-msft
Copy link
Member

Meh, yea, that's what we get when we try distilling a big release like this into two sentences 😆

There's actually quite a lot of configuration possible - see the docs for globalSummon

@DHowett
Copy link
Member

DHowett commented May 25, 2021

If the team consensus is that Quake Mode was designed to be a gimmick and not a useful feature.

This is not the team's consensus. An "easter egg" that is a specialization of a much more featureful feature is not "a gimmick" that was designed to be "not a useful feature."

Please assume positive intent when you're on this repository. 😄

@riverar
Copy link
Author

riverar commented May 25, 2021

Thanks @DHowett no negative vibes intended. But I completely disagree with your characterization of Quake Mode as an easter egg. It's not communicated that way via official Microsoft comms channels. And "easter egg" implies "no support", hence my comment. Happy to be wrong there.

Regardless, @zadjii-msft's workaround is great, so no changes needed! Closing issue.

@riverar riverar closed this as completed May 25, 2021
@xinxilas
Copy link

xinxilas commented Aug 3, 2021

Thanks @DHowett no negative vibes intended. But I completely disagree with your characterization of Quake Mode as an easter egg. It's not communicated that way via official Microsoft comms channels. And "easter egg" implies "no support", hence my comment. Happy to be wrong there.

Regardless, @zadjii-msft's workaround is great, so no changes needed! Closing issue.

Sorry but how did you mannaged to adapt quake mode on ultra wide using the globalSummon directives ? I would like to open the quake mode at the middle of a really big screen with 50% width

@riverar
Copy link
Author

riverar commented Aug 3, 2021

@xinxilas I didn't. Wasn't worth the trouble.

@xinxilas
Copy link

xinxilas commented Aug 3, 2021

Lol, ill try to use some custom globalsummon with without quake mode then 😂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. Needs-Attention The core contributors need to come back around and look at this ASAP. Needs-Tag-Fix Doesn't match tag requirements Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Product-Terminal The new Windows Terminal.
Projects
None yet
Development

No branches or pull requests

4 participants