Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't bind backtick with Colemak keyboard layout #10776

Closed
Vynce opened this issue Jul 23, 2021 · 6 comments
Closed

Can't bind backtick with Colemak keyboard layout #10776

Vynce opened this issue Jul 23, 2021 · 6 comments
Labels
Product-Terminal The new Windows Terminal. Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing.

Comments

@Vynce
Copy link

Vynce commented Jul 23, 2021

Windows Terminal version (or Windows build number)

1.9.1942.0

Other Software

https://colemak.com/Windows

Steps to reproduce

  1. Install the Colemak keyboard layout and set it active.
  2. Add a key binding like this:
    { "command": { "action": "globalSummon", "monitor": "any", "toggleVisibility": false }, "keys": "ctrl+`" }
  3. The Terminal settings GUI sees that as ctrl+alt+r (and pressing that key combo does make the Terminal window active):
    image
  4. Switch to the US English keyboard layout.
  5. Restart Terminal.
  6. The settings GUI now sees the backtick key combos correctly (and pressing ctrl+` makes the Terminal window active):
    image
  7. Switch the keyboard layout back to Colemak.
  8. Pressing ctrl+` continues to activate the Terminal window until Terminal is restarted.

Expected Behavior

Backtick key bindings should function as backtick key bindings.

Actual Behavior

Backtick key bindings get redefined to some combination of ctrl+alt+r.

@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Jul 23, 2021
@skyline75489
Copy link
Collaborator

/cc @lhecker

@zadjii-msft zadjii-msft added the Product-Terminal The new Windows Terminal. label Jul 26, 2021
@lhecker
Copy link
Member

lhecker commented Jul 27, 2021

We use MapVirtualKeyW to map characters like ` to virtual keys, which are then used to create key bindinggs. This mapping generally isn't accurate, but there's no other "good way" to map characters to virtual keys except using MapVirtualKeyW.

I tried solving this issue in #10666, which will be released in a future update. It'll redefine the quake mode hotkey to be win+sc(41), which will allow it to work independent of keyboard layout.

But despite this we still have the issue described in #10729, which needs to be fixed in order for a change in the keyboard layout to trigger a reload of the quake mode and other key bindings.

@Vynce
Copy link
Author

Vynce commented Aug 2, 2021

Thanks for taking a look! I'm looking forward to trying a new build when it's available 😊.

@zadjii-msft
Copy link
Member

Okay great! This should be fixed in 1.11, but let us know if it isn't and we'll reopen this. Thanks!

/dup #10666

@ghost
Copy link

ghost commented Aug 5, 2021

Hi! We've identified this issue as a duplicate of another one that already exists on this Issue Tracker. This specific instance is being closed in favor of tracking the concern over on the referenced thread. Thanks for your report!

@ghost ghost closed this as completed Aug 5, 2021
@ghost ghost added Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing. and removed Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Aug 5, 2021
@Vynce
Copy link
Author

Vynce commented Aug 31, 2021

This is working for me in 1.11.2421.0 after changing the key binding to
{ "command": { "action": "globalSummon", "monitor": "any", "toggleVisibility": false }, "keys": "ctrl+sc(41)" }
Thanks!

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Product-Terminal The new Windows Terminal. Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing.
Projects
None yet
Development

No branches or pull requests

4 participants