Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add links to the docs (and maybe the SUI) to infobars #11187

Open
zadjii-msft opened this issue Sep 9, 2021 · 4 comments
Open

Add links to the docs (and maybe the SUI) to infobars #11187

zadjii-msft opened this issue Sep 9, 2021 · 4 comments
Labels
Area-User Interface Issues pertaining to the user interface of the Console or Terminal Help Wanted We encourage anyone to jump in on these. Issue-Task It's a feature request, but it doesn't really need a major design. Product-Terminal The new Windows Terminal.
Milestone

Comments

@zadjii-msft
Copy link
Member

How hard would it be to add a link to the docs (like, to https://docs.microsoft.com/en-us/windows/terminal/customize-settings/profile-advanced#profile-termination-behavior) to that infobar? We could generate the fwlink if needed

@zadjii-msft - this is not very hard. We can do something like

image

but we need to decide if we want to follow up by opening the settings 😊.... or... we can do all of them:
image

In any case suggest to do it in a follow up. I can open a ticket for it.. and proceed with it if the team is interested.

Originally posted by @Don-Vito in #11139 (comment)

@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Sep 9, 2021
@zadjii-msft
Copy link
Member Author

zadjii-msft commented Sep 9, 2021

I turned this into an issue preemptively so we didn't lose track of it. I'll discuss with the team which style they like more (on Monday in our regular sync).

I personally like the hyperlink more (though I pictured it inline with the rest of the text, like

"Termination Behavior can be configured in advanced profile settings. See documentation here         don't show again").

I also hadn't even thought about the possibility of linking directly to the SUI. If that's even possible, then we should probably go with 2.

@zadjii-msft zadjii-msft added Needs-Discussion Something that requires a team discussion before we can proceed Product-Terminal The new Windows Terminal. Area-User Interface Issues pertaining to the user interface of the Console or Terminal labels Sep 9, 2021
@Don-Vito
Copy link
Contributor

BTW, there is also a third option:

image

@cinnamon-msft
Copy link
Contributor

I wouldn't put the radio buttons inside the info bar. I think that breaks a lot of design rules and guarantees they click "Don't show again" 😋.

I like the first two options, but I'm unsure which I like more. The first is just a one-click for dismissing the info bar, rather than two. However, the second makes it easier to modify the setting since it takes you there directly.

@zadjii-msft
Copy link
Member Author

Team consensus was that the first option was a fine incremental update, but the second would be a good "north star" vision. If the first one is much more easily doable, then that's totally fine to ship as an incremental step towards the second (which would presumably require a lot more work).

@zadjii-msft zadjii-msft added this to the Terminal Backlog milestone Sep 13, 2021
@zadjii-msft zadjii-msft added Help Wanted We encourage anyone to jump in on these. Issue-Task It's a feature request, but it doesn't really need a major design. and removed Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Discussion Something that requires a team discussion before we can proceed labels Sep 13, 2021
@ghost ghost removed the Needs-Tag-Fix Doesn't match tag requirements label Sep 13, 2021
@zadjii-msft zadjii-msft modified the milestones: Terminal Backlog, Backlog Jan 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-User Interface Issues pertaining to the user interface of the Console or Terminal Help Wanted We encourage anyone to jump in on these. Issue-Task It's a feature request, but it doesn't really need a major design. Product-Terminal The new Windows Terminal.
Projects
None yet
Development

No branches or pull requests

3 participants