Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quake Mode - Can we have Tab title to show how many tabs we have on quake mode? #11935

Closed
amithegde opened this issue Dec 13, 2021 · 5 comments
Closed
Labels
Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing.

Comments

@amithegde
Copy link

Description of the new feature/enhancement

When in quake mode, if we have multiple tabs open, it's hard to notice there are multiple tabs. On ConEmu, we get this little title to show list of tabs open which makes it convenient.

Proposed technical implementation details (optional)

If we can have a title at the top which shows tabs open which can be selected and organized if need be (drag and drop), will come handy.

@amithegde amithegde added the Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. label Dec 13, 2021
@ghost ghost added Needs-Tag-Fix Doesn't match tag requirements Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting labels Dec 13, 2021
@Rosefield
Copy link
Contributor

On the quake window you can make the tabs show if you disable focus mode using the Toggle focus mode action in command palette. This will make it show the normal tab interface like other terminal windows.

@zadjii-msft
Copy link
Member

Thanks for the feedback! This is a known limitation atm. You can always exit focus mode, with ctrl+shift+p, "Toggle Focus Mode" (or whatever that's localized to). Otherwise, I'm gonna call this /dup #9992, which should enable adding a setting to disable this for the _quake window by default.

@ghost
Copy link

ghost commented Dec 13, 2021

Hi! We've identified this issue as a duplicate of another one that already exists on this Issue Tracker. This specific instance is being closed in favor of tracking the concern over on the referenced thread. Thanks for your report!

@ghost ghost closed this as completed Dec 13, 2021
@ghost ghost added Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing. and removed Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Dec 13, 2021
@xorinzor
Copy link

@Rosefield @zadjii-msft why is this issue closed when this is clearly a bug though?
Launch mode can only be configured to "Default", "Maximized", "Full screen", "Focus" or "Maximized Focus".

In quake mode I won't be using Maximized or Full screen and I'm trying to disable Focus mode because I want the tabs to always be visible. Having it set to "Default" I'd expect Focus mode to be disabled.

Yet every time Quake mode is launched it is showing no tabs and I first need to do the ctrl+shift+p trick to Toggle focus mode.

This really sounds like the app not respecting the configured settings when lauched in quake mode and thus a bug.

What's worse is how this is an issue that's been known since Dec 2021, and it still hasn't been addressed..

@zadjii-msft
Copy link
Member

Why is this closed?

Because ultimately, we're going to solve this by doing #9992, so it doesn't make sense for us (from a project management perspective) to have multiple threads all for the same root cause/fix.

Quake mode has always been an "easter egg" version of globalSummon, which is more general-purpose. The only real thing from the _quake window you can't accomplish with generic globalSummon actions is the "snap to the top" behavior (which is tracked by a point in #8888 but apparently doesn't have it's own thread).

What's worse is how this is an issue that's been known since Dec 2021, and it still hasn't been addressed

Alas, I haven't had any cycles to work on anything globalSummon related in a long while. You'll note there are many issues on the backlog even older than #9992 that are still open. We're doing our best, but engineering work does take time.

If there's interest, I could probably add a writeup to #9992 for how I'd implement it. It'd be a lot of code shuffling, but not anything too hard, I don't think. Alternatively, the snapToSide global setting would be pretty easy, which could then be combined with globalSummon so you didn't need to use specifically the _quake window.

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing.
Projects
None yet
Development

No branches or pull requests

4 participants