Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ContentDialog crash on teardown after displaying settings error #11980

Closed
vefatica opened this issue Dec 16, 2021 · 9 comments
Closed

ContentDialog crash on teardown after displaying settings error #11980

vefatica opened this issue Dec 16, 2021 · 9 comments
Labels
Area-UserInterface Issues pertaining to the user interface of the Console or Terminal Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Tag-Fix Doesn't match tag requirements Priority-2 A description (P2) Product-Terminal The new Windows Terminal. Resolution-External For issues that are outside this codebase Severity-Crash Crashes are real bad news.

Comments

@vefatica
Copy link

vefatica commented Dec 16, 2021

Could be a dup; I didn't search. I usually run the preview release. When I start the most recent "stable" release, I get this.

image

When I dismiss it, I get a rather plain WT running Powershell. When I exit Powershell I get one of these.

WindowsTerminal.exe.520.dmp.zip

@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Dec 16, 2021
@DHowett
Copy link
Member

DHowett commented Dec 16, 2021

It looks like you're using settings from Preview 1.12 on Stable 1.11. It was only 1.12 that added support for directional splits...

@DHowett
Copy link
Member

DHowett commented Dec 16, 2021

I didn't search

We would absolutely appreciate it if you did search. Just in general.

I'm looking at your crash dump right now.

@DHowett
Copy link
Member

DHowett commented Dec 16, 2021

This looks like one of our classic crashes during teardown‚ unrelated to the settings. I'm not particularly worried about it -- it creates noise for us, and makes relaunch a little slower because the IPC blocks on the dead process, but... we'll fix these all-up at some point in the future.

@vefatica
Copy link
Author

It looks like you're using settings from Preview 1.12 on Stable 1.11. It was only 1.12 that added support for directional splits...

I figured that much. Both my installs are unzip-only so I think they use the same ini file, namely C:\Users\vefatica\AppData\Local\Microsoft\Windows Terminal\settings.json.

But a crash is a rather harsh reaction to a bad spec in an ini file.

Can't (at least some) settings errors be overlooked and the file used anyway?

@DHowett
Copy link
Member

DHowett commented Dec 16, 2021

  1. Yes, we should demote some of our errors to warnings.
  2. The crash is not directly related to loading an "invalid" settings document; rather, it is a crash on teardown because we presented a dialog box 😉

@DHowett DHowett changed the title Error in settings.json leads to crash ContentDialog crash on teardown after displaying settings error Dec 16, 2021
@DHowett DHowett added the Severity-Crash Crashes are real bad news. label Dec 16, 2021
@DHowett DHowett added this to the Terminal v1.14 milestone Dec 16, 2021
@DHowett DHowett added Area-UserInterface Issues pertaining to the user interface of the Console or Terminal Issue-Bug It either shouldn't be doing this or needs an investigation. Priority-2 A description (P2) Product-Terminal The new Windows Terminal. labels Dec 16, 2021
@ghost ghost removed the Needs-Tag-Fix Doesn't match tag requirements label Dec 16, 2021
@DHowett DHowett removed the Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting label Dec 16, 2021
@zadjii-msft
Copy link
Member

Am I crazy? There doesn't seem to be anything of value in that dump:

0:000> ~*k

.  0  Id: 208.1938 Suspend: 0 Teb: 0000001d`99bb2000 Unfrozen
 # Child-SP          RetAddr               Call Site
00 0000001d`9995de18 00007fff`cb02cb20     ntdll!ZwWaitForMultipleObjects+0x14 [minkernel\ntdll\daytona\objfre\amd64\usrstubs.asm @ 907] 
01 0000001d`9995de20 00000000`00000000     KERNELBASE+0x4cb20
0:000> !analyze -v
*******************************************************************************
*                                                                             *
*                        Exception Analysis                                   *
*                                                                             *
*******************************************************************************


KEY_VALUES_STRING: 1

    Key  : AV.Dereference
    Value: NullClassPtr

    Key  : AV.Fault
    Value: Read

    Key  : Analysis.CPU.mSec
    Value: 343

    Key  : Analysis.DebugAnalysisManager
    Value: Create

    Key  : Analysis.Elapsed.mSec
    Value: 183725

    Key  : Analysis.Init.CPU.mSec
    Value: 312

    Key  : Analysis.Init.Elapsed.mSec
    Value: 175931

    Key  : Analysis.Memory.CommitPeak.Mb
    Value: 192

    Key  : Stack.Best.Hash
    Value: 1fe04a2ef3f17cfbbad2de29f05ec21756922595

    Key  : Stack.Best.SymbolType
    Value: None

    Key  : Timeline.Process.Start.DeltaSec
    Value: 5

    Key  : WER.OS.Branch
    Value: vb_release

    Key  : WER.OS.Timestamp
    Value: 2019-12-06T14:06:00Z

    Key  : WER.OS.Version
    Value: 10.0.19041.1


FILE_IN_CAB:  WindowsTerminal.exe.520.dmp

NTGLOBALFLAG:  0

PROCESS_BAM_CURRENT_THROTTLED: 0

PROCESS_BAM_PREVIOUS_THROTTLED: 0

APPLICATION_VERIFIER_FLAGS:  0

CONTEXT:  (.ecxr)
rax=0000000000000000 rbx=0000000000000000 rcx=4cde5fb7503e0000
rdx=00007fffb3c2c828 rsi=0000020b58760340 rdi=0000020b58760340
rip=00007fffb436b3ee rsp=0000001d9995f350 rbp=0000001d9995f3b0
 r8=0000001d9995ee30  r9=0000000000000001 r10=00000ffff6724dbc
r11=1000040110010000 r12=00007fff990c35d0 r13=0000000000000000
r14=0000020b587607d8 r15=0000020b4ef5e670
iopl=0         nv up ei pl nz na pe nc
cs=0033  ss=002b  ds=002b  es=002b  fs=0053  gs=002b             efl=00010202
Windows_UI_Xaml+0xacb3ee:
00007fff`b436b3ee 488bb830010000  mov     rdi,qword ptr [rax+130h] ds:00000000`00000130=????????????????
Resetting default scope

EXCEPTION_RECORD:  (.exr -1)
ExceptionAddress: 00007fffb436b3ee (Windows_UI_Xaml+0x0000000000acb3ee)
   ExceptionCode: c0000005 (Access violation)
  ExceptionFlags: 00000000
NumberParameters: 2
   Parameter[0]: 0000000000000000
   Parameter[1]: 0000000000000130
Attempt to read from address 0000000000000130

PROCESS_NAME:  WindowsTerminal.exe

READ_ADDRESS:  0000000000000130 

ERROR_CODE: (NTSTATUS) 0xc0000005 - The instruction at 0x%p referenced memory at 0x%p. The memory could not be %s.

EXCEPTION_CODE_STR:  c0000005

EXCEPTION_PARAMETER1:  0000000000000000

EXCEPTION_PARAMETER2:  0000000000000130

RETRACER_ANALYSIS_TAG_STATUS:  Stop retracer because there is just a single frame

STACK_TEXT:  
0000001d`9995f350 00000000`00000000     : 00000000`00000000 0000020b`58760760 00007fff`b4038af6 00000000`00000000 : Windows_UI_Xaml+0xacb3ee


STACK_COMMAND:  ~0s; .ecxr ; kb

SYMBOL_NAME:  Windows_UI_Xaml+acb3ee

MODULE_NAME: Windows_UI_Xaml

IMAGE_NAME:  Windows.UI.Xaml.dll

FAILURE_BUCKET_ID:  NULL_CLASS_PTR_READ_c0000005_Windows.UI.Xaml.dll!Unknown

OS_VERSION:  10.0.19041.1

BUILDLAB_STR:  vb_release

OSPLATFORM_TYPE:  x64

OSNAME:  Windows 10

IMAGE_VERSION:  10.0.19041.1387

FAILURE_ID_HASH:  {c4d27594-2a0e-5388-c276-d3aa89ea8e8b}

FAILURE_ID_REPORT_LINK: https://go.microsoft.com/fwlink/?LinkID=397724&FailureSearchText=c4d27594-2a0e-5388-c276-d3aa89ea8e8b

Followup:     MachineOwner
---------

Like, a single WinUI stack frame and nothing else, I'm not even sure how to start investigating that.

@vefatica Do you have more consistent repro steps?

@zadjii-msft zadjii-msft added the Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something label Jan 28, 2022
@vefatica
Copy link
Author

Huh? It's pretty consistent. With this

        {
            "command": 
            {
                "action": "splitPane",
                "index": 5,
                "split": "down"
            },
            "keys": "alt+shift+a"
        },

1.11 gives the "failed to load settings" message (doesn't know about "down"), runs with a default set-up, and generates a dump upon exit. Here's one from today. If it doesn't look like there's anything wrong then I suppose the dump shouldn't have been generated.

WindowsTerminal.exe.7660.dmp.zip

@ghost ghost added Needs-Attention The core contributors need to come back around and look at this ASAP. and removed Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something labels Jan 28, 2022
@zadjii-msft
Copy link
Member

WILD. Last week when I looked at the dump, it looked totally corrupted. This week, there's an actual stack in it, an exception, things we can use!

CONTEXT:  (.ecxr)
rax=0000000000000000 rbx=0000000000000000 rcx=098e827a64230000
rdx=00007ff86cc5c828 rsi=0000022c0fc7a1f0 rdi=0000022c0fc7a1f0
rip=00007ff86d39b3ee rsp=000000d71bf0f260 rbp=000000d71bf0f2c0
 r8=000000d71bf0ed40  r9=0000000000000001 r10=00000fff0d92adbc
r11=1000040110010000 r12=00007ff8443635d0 r13=0000000000000000
r14=0000022c0fc7a688 r15=0000022c0655c050
iopl=0         nv up ei pl nz na po nc
cs=0033  ss=002b  ds=002b  es=002b  fs=0053  gs=002b             efl=00010206
Windows_UI_Xaml!DirectUI::DXamlCore::GetWindow+0xb [inlined in Windows_UI_Xaml!DirectUI::ContentDialog::DetachEventHandlersForOpenDialog+0x46]:
00007ff8`6d39b3ee 488bb830010000  mov     rdi,qword ptr [rax+130h] ds:00000000`00000130=????????????????
Resetting default scope

EXCEPTION_RECORD:  (.exr -1)
ExceptionAddress: 00007ff86d39b3ee (Windows_UI_Xaml!DirectUI::DXamlCore::GetWindow+0x000000000000000b)
   ExceptionCode: c0000005 (Access violation)
  ExceptionFlags: 00000000
NumberParameters: 2
   Parameter[0]: 0000000000000000
   Parameter[1]: 0000000000000130
Attempt to read from address 0000000000000130

READ_ADDRESS:  0000000000000130 

ERROR_CODE: (NTSTATUS) 0xc0000005 - The instruction at 0x%p referenced memory at 0x%p. The memory could not be %s.


RETRACER_ANALYSIS_TAG_SYMBOL:  windows_ui_xaml!DirectUI::ContentDialog::DetachEventHandlersForOpenDialog

RETRACER_ANALYSIS_TAG_FAILUREIP: 7ff86d39b3de

RETRACER_ANALYSIS_TAG_STATUS:  Set followup:  symbol windows_ui_xaml!DirectUI::ContentDialog::DetachEventHandlersForOpenDialog FailureIP 7ff86d39b3de BadPtrLoc 0 #Insts: 0 ParsingError: 0 ReptStopCode: 0 #Iters: 0 elapsed time 3578 Memory: -1

STACK_TEXT:  
000000d7`1bf0f260 00007ff8`6d397d6b     : 00000000`00000001 00000000`00000001 0000022c`0655c050 0000022c`0fc7a1f0 : Windows_UI_Xaml!DirectUI::ContentDialog::DetachEventHandlersForOpenDialog+0x46
000000d7`1bf0f2e0 00007ff8`6cf69204     : 0000022c`0658db68 00000000`00000001 0000022c`0655c050 0000022c`0655c050 : Windows_UI_Xaml!DirectUI::ContentDialog::~ContentDialog+0x1f
000000d7`1bf0f310 00007ff8`6cb1f037     : 00000000`00000000 0000022c`0655c120 000000d7`1bf0f4c8 0000022c`0655c050 : Windows_UI_Xaml!ctl::ComObject<DirectUI::ContentDialog>::`scalar deleting destructor'+0x18
000000d7`1bf0f340 00007ff8`443ab255     : 0000022c`0658dad0 0000022c`0655c120 0000022c`0658dad0 0000022c`0658dad0 : Windows_UI_Xaml!ctl::ComBase::ReleaseImpl+0x87
000000d7`1bf0f370 00007ff8`443ab7f0     : 00000000`00000000 00007ff8`443393e0 00000000`00000000 00000000`00000000 : TerminalApp!winrt::TerminalApp::implementation::AppLogic::~AppLogic+0xb5
000000d7`1bf0f3a0 00007ff8`44399ac1     : 0000022c`0658daf0 00000000`00000040 00002c41`6898158d 00007ff8`7958986b : TerminalApp!winrt::impl::heap_implements<winrt::TerminalApp::implementation::AppLogic>::`scalar deleting destructor'+0x14
000000d7`1bf0f3d0 00007ff8`794542d6     : 00000d67`1cf6336b 0000022c`0655c110 00000000`0000001f 00007ff8`794560ae : TerminalApp!winrt::implements<winrt::TerminalApp::implementation::AppLogic,winrt::TerminalApp::AppLogic,winrt::TerminalApp::IDirectKeyListener,winrt::TerminalApp::IDialogPresenter,IInitializeWithWindow>::Release+0x4ec31
000000d7`1bf0f400 00007ff8`794541fb     : 00000000`00000000 000000d7`1bf0f4c8 000000d7`1bf0f790 00007ff8`79530e40 : ucrtbase!<lambda_f03950bc5685219e0bcd2087efbe011e>::operator()+0xa6
000000d7`1bf0f450 00007ff8`794541b4     : 00000000`00000000 00000000`00000001 00007ff8`44300000 000000d7`1bf0f4b8 : ucrtbase!__crt_seh_guarded_call<int>::operator()<<lambda_7777bce6b2f8c936911f934f8298dc43>,<lambda_f03950bc5685219e0bcd2087efbe011e> &,<lambda_3883c3dff614d5e0c5f61bb1ac94921c> >+0x3b
000000d7`1bf0f480 00007ff8`44363459     : 00007ff8`445a79c8 00000000`00000002 00000000`00000002 000000d7`1bf0f4b0 : ucrtbase!_execute_onexit_table+0x34
000000d7`1bf0f4b0 00007ff8`4436357a     : 00000000`00000001 00000000`00000000 00000000`00000010 00000000`00000000 : TerminalApp!dllmain_crt_process_detach+0x45
000000d7`1bf0f4f0 00007ff8`7bca9a1d     : 00007ff8`44300000 00000000`00000000 00000000`00000001 00000000`7ffe0385 : TerminalApp!dllmain_dispatch+0xe6
000000d7`1bf0f550 00007ff8`7bcedb91     : 0000022c`06550ce0 00007ff8`44300000 00007ff8`00000000 0000022c`06550d00 : ntdll!LdrpCallInitRoutine+0x61
000000d7`1bf0f5c0 00007ff8`7bceda2d     : 00000000`00000000 00000000`00000000 00000000`00000000 00000000`00000000 : ntdll!LdrShutdownProcess+0x141
000000d7`1bf0f6c0 00007ff8`7a1fe0ab     : 00000000`00000000 00000000`00000000 00007ff8`794fd3a0 000000d7`1bf0f790 : ntdll!RtlExitUserProcess+0xad
000000d7`1bf0f6f0 00007ff8`794605bc     : 00000000`00000000 00000000`00000000 000000d7`1bf0f778 00007ff8`79530e40 : kernel32!FatalExit+0xb
000000d7`1bf0f720 00007ff8`7946045f     : 00000000`00000000 00000000`00000000 00000000`00000000 000000d7`1bf0f770 : ucrtbase!exit_or_terminate_process+0x44
000000d7`1bf0f750 00007ff6`b5d2c4e4     : 00000000`00000000 00000000`00000000 00000000`00000000 00000000`00000001 : ucrtbase!common_exit+0x6f
000000d7`1bf0f7a0 00007ff8`7a1f7034     : 00000000`00000000 00000000`00000000 00000000`00000000 00000000`00000000 : WindowsTerminal!__scrt_common_main_seh+0x168
000000d7`1bf0f7e0 00007ff8`7bce2651     : 00000000`00000000 00000000`00000000 00000000`00000000 00000000`00000000 : kernel32!BaseThreadInitThunk+0x14
000000d7`1bf0f810 00000000`00000000     : 00000000`00000000 00000000`00000000 00000000`00000000 00000000`00000000 : ntdll!RtlUserThreadStart+0x21


STACK_COMMAND:  ~0s; .ecxr ; kb

FAULTING_SOURCE_LINE:  onecoreuap\windows\dxaml\xcp\dxaml\lib\contentdialog_partial.cpp

FAULTING_SOURCE_FILE:  onecoreuap\windows\dxaml\xcp\dxaml\lib\contentdialog_partial.cpp

FAULTING_SOURCE_LINE_NUMBER:  2507


OS_VERSION:  10.0.19044.1

BUILDLAB_STR:  vb_release

OSPLATFORM_TYPE:  x64

OSNAME:  Windows 10

IMAGE_VERSION:  10.0.19041.1466

FAILURE_ID_HASH:  {4c5267ed-b267-13fa-6757-277ed9c7dc15}

FAILURE_ID_REPORT_LINK: https://go.microsoft.com/fwlink/?LinkID=397724&FailureSearchText=4c5267ed-b267-13fa-6757-277ed9c7dc15

0:000> ~*k

.  0  Id: 1dec.239c Suspend: 0 Teb: 000000d7`1c1bb000 Unfrozen
 # Child-SP          RetAddr               Call Site
00 000000d7`1bf0dd18 00007ff8`7958cb20     ntdll!ZwWaitForMultipleObjects+0x14 [minkernel\ntdll\daytona\objfre\amd64\usrstubs.asm @ 907] 
01 000000d7`1bf0dd20 00007ff8`7958ca1e     KERNELBASE!WaitForMultipleObjectsEx+0xf0 [minkernel\kernelbase\synch.c @ 1551] 
02 000000d7`1bf0e010 00007ff8`7a25092a     KERNELBASE!WaitForMultipleObjects+0xe [minkernel\kernelbase\synch.c @ 1403] 
03 000000d7`1bf0e050 00007ff8`7a250366     kernel32!WerpReportFaultInternal+0x58a [onecore\windows\feedback\core\faultrep\lib\faultrep.cpp @ 997] 
04 000000d7`1bf0e170 00007ff8`7964ba49     kernel32!WerpReportFault+0xbe [onecore\windows\feedback\core\faultrep\lib\faultrep.cpp @ 1308] 
05 000000d7`1bf0e1b0 00007ff8`7bd351b0     KERNELBASE!UnhandledExceptionFilter+0x3d9 [minkernel\kernelbase\xcpt.c @ 686] 
06 (Inline Function) --------`--------     ntdll!RtlpThreadExceptionFilter+0x91 [minkernel\ntdll\rtlstrt.c @ 957] 
07 000000d7`1bf0e2d0 00007ff8`7bd1c766     ntdll!RtlUserThreadStart$filt$0+0xa2 [minkernel\ntdll\rtlstrt.c @ 1154] 
08 000000d7`1bf0e310 00007ff8`7bd320cf     ntdll!__C_specific_handler+0x96 [minkernel\crts\crtw32\misc\riscchandler.c @ 352] 
09 000000d7`1bf0e380 00007ff8`7bce1454     ntdll!RtlpExecuteHandlerForException+0xf [minkernel\ntos\rtl\amd64\xcptmisc.asm @ 132] 
0a 000000d7`1bf0e3b0 00007ff8`7bd30bfe     ntdll!RtlDispatchException+0x244 [minkernel\ntos\rtl\amd64\exdsptch.c @ 595] 
0b 000000d7`1bf0eac0 00007ff8`6d39b3ee     ntdll!KiUserExceptionDispatch+0x2e [minkernel\ntos\rtl\amd64\trampoln.asm @ 751] 
0c (Inline Function) --------`--------     Windows_UI_Xaml!ctl::EventPtrBase<ctl::event_handler<Windows::Foundation::ITypedEventHandler<Windows::Graphics::Display::DisplayInformation *,IInspectable *>,Windows::Graphics::Display::IDisplayInformation,IInspectable,DirectUI::DisplayInformationOrientationChangedTraits> >::operator bool+0x7 [onecoreuap\windows\dxaml\xcp\components\com\inc\comEventHandler.h @ 264] 
0d 000000d7`1bf0f260 00007ff8`6d397d6b     Windows_UI_Xaml!DirectUI::ContentDialog::DetachEventHandlersForOpenDialog+0x46 [onecoreuap\windows\dxaml\xcp\dxaml\lib\contentdialog_partial.cpp @ 2507] 
0e 000000d7`1bf0f2e0 00007ff8`6cf69204     Windows_UI_Xaml!DirectUI::ContentDialog::~ContentDialog+0x1f [onecoreuap\windows\dxaml\xcp\dxaml\lib\contentdialog_partial.cpp @ 74] 
0f 000000d7`1bf0f310 00007ff8`6cb1f037     Windows_UI_Xaml!ctl::ComObject<DirectUI::ContentDialog>::`scalar deleting destructor'+0x18
10 000000d7`1bf0f340 00007ff8`443ab255     Windows_UI_Xaml!ctl::ComBase::ReleaseImpl+0x87 [onecoreuap\windows\dxaml\xcp\components\com\inc\ComBase.h @ 307] 
11 000000d7`1bf0f370 00007ff8`443ab7f0     TerminalApp!winrt::TerminalApp::implementation::AppLogic::~AppLogic+0xb5 [C:\a\_work\1\s\src\cascadia\TerminalApp\AppLogic.h @ 45] 
12 000000d7`1bf0f3a0 00007ff8`44399ac1     TerminalApp!winrt::impl::heap_implements<winrt::TerminalApp::implementation::AppLogic>::`scalar deleting destructor'+0x14
13 (Inline Function) --------`--------     TerminalApp!winrt::impl::root_implements<winrt::TerminalApp::implementation::AppLogic,winrt::TerminalApp::AppLogic,winrt::TerminalApp::IDirectKeyListener,winrt::TerminalApp::IDialogPresenter,IInitializeWithWindow>::NonDelegatingRelease+0x4ec23 [C:\a\_work\1\s\src\cascadia\TerminalApp\Generated Files\winrt\base.h @ 7325] 
14 (Inline Function) --------`--------     TerminalApp!winrt::impl::root_implements<winrt::TerminalApp::implementation::AppLogic,winrt::TerminalApp::AppLogic,winrt::TerminalApp::IDirectKeyListener,winrt::TerminalApp::IDialogPresenter,IInitializeWithWindow>::Release+0x4ec23 [C:\a\_work\1\s\src\cascadia\TerminalApp\Generated Files\winrt\base.h @ 7206] 
15 000000d7`1bf0f3d0 00007ff8`794542d6     TerminalApp!winrt::implements<winrt::TerminalApp::implementation::AppLogic,winrt::TerminalApp::AppLogic,winrt::TerminalApp::IDirectKeyListener,winrt::TerminalApp::IDialogPresenter,IInitializeWithWindow>::Release+0x4ec31 [C:\a\_work\1\s\src\cascadia\TerminalApp\Generated Files\winrt\base.h @ 7802] 
16 000000d7`1bf0f400 00007ff8`794541fb     ucrtbase!<lambda_f03950bc5685219e0bcd2087efbe011e>::operator()+0xa6 [minkernel\crts\ucrt\src\appcrt\startup\onexit.cpp @ 206] 
17 000000d7`1bf0f450 00007ff8`794541b4     ucrtbase!__crt_seh_guarded_call<int>::operator()<<lambda_7777bce6b2f8c936911f934f8298dc43>,<lambda_f03950bc5685219e0bcd2087efbe011e> &,<lambda_3883c3dff614d5e0c5f61bb1ac94921c> >+0x3b [VCCRT\vcruntime\inc\internal_shared.h @ 204] 
18 (Inline Function) --------`--------     ucrtbase!__acrt_lock_and_call+0x1c [minkernel\crts\ucrt\inc\corecrt_internal.h @ 976] 
19 000000d7`1bf0f480 00007ff8`44363459     ucrtbase!_execute_onexit_table+0x34 [minkernel\crts\ucrt\src\appcrt\startup\onexit.cpp @ 231] 
1a 000000d7`1bf0f4b0 00007ff8`4436357a     TerminalApp!dllmain_crt_process_detach+0x45 [d:\a01\_work\6\s\src\vctools\crt\vcstartup\src\startup\dll_dllmain.cpp @ 182] 
1b 000000d7`1bf0f4f0 00007ff8`7bca9a1d     TerminalApp!dllmain_dispatch+0xe6 [d:\a01\_work\6\s\src\vctools\crt\vcstartup\src\startup\dll_dllmain.cpp @ 293] 
1c 000000d7`1bf0f550 00007ff8`7bcedb91     ntdll!LdrpCallInitRoutine+0x61 [minkernel\ntdll\ldr.c @ 212] 
1d 000000d7`1bf0f5c0 00007ff8`7bceda2d     ntdll!LdrShutdownProcess+0x141 [minkernel\ntdll\ldrinit.c @ 6216] 
1e 000000d7`1bf0f6c0 00007ff8`7a1fe0ab     ntdll!RtlExitUserProcess+0xad [minkernel\ntdll\rtlstrt.c @ 1571] 
1f 000000d7`1bf0f6f0 00007ff8`794605bc     kernel32!FatalExit+0xb [clientcore\base\win32\client\process.c @ 2421] 
20 000000d7`1bf0f720 00007ff8`7946045f     ucrtbase!exit_or_terminate_process+0x44 [minkernel\crts\ucrt\src\appcrt\startup\exit.cpp @ 143] 
21 000000d7`1bf0f750 00007ff6`b5d2c4e4     ucrtbase!common_exit+0x6f [minkernel\crts\ucrt\src\appcrt\startup\exit.cpp @ 280] 
22 000000d7`1bf0f7a0 00007ff8`7a1f7034     WindowsTerminal!__scrt_common_main_seh+0x168 [d:\a01\_work\6\s\src\vctools\crt\vcstartup\src\startup\exe_common.inl @ 295] 
23 000000d7`1bf0f7e0 00007ff8`7bce2651     kernel32!BaseThreadInitThunk+0x14 [clientcore\base\win32\client\thread.c @ 64] 
24 000000d7`1bf0f810 00000000`00000000     ntdll!RtlUserThreadStart+0x21 [minkernel\ntdll\rtlstrt.c @ 1153] 

Looks like the underlying crash is MSFT:26130824, which is fixed in Windows 11. Based on the fairly low number of hist and the fact that the crash is only once the app is already exiting, I don't think we'll be able to get that one serviced 😕 Thanks for reporting anyways!

/dup https://task.ms/26130824

@ghost
Copy link

ghost commented Feb 3, 2022

Hi! We've identified this issue as a duplicate of one that exists on somebody else's Issue Tracker. Please make sure you subscribe to the referenced external issue for future updates. Thanks for your report!

@ghost ghost added Resolution-External For issues that are outside this codebase Needs-Tag-Fix Doesn't match tag requirements and removed Needs-Attention The core contributors need to come back around and look at this ASAP. labels Feb 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-UserInterface Issues pertaining to the user interface of the Console or Terminal Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Tag-Fix Doesn't match tag requirements Priority-2 A description (P2) Product-Terminal The new Windows Terminal. Resolution-External For issues that are outside this codebase Severity-Crash Crashes are real bad news.
Projects
None yet
Development

No branches or pull requests

3 participants