-
Notifications
You must be signed in to change notification settings - Fork 8.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ContentDialog crash on teardown after displaying settings error #11980
Comments
It looks like you're using settings from Preview 1.12 on Stable 1.11. It was only 1.12 that added support for directional splits... |
We would absolutely appreciate it if you did search. Just in general. I'm looking at your crash dump right now. |
This looks like one of our classic crashes during teardown‚ unrelated to the settings. I'm not particularly worried about it -- it creates noise for us, and makes relaunch a little slower because the IPC blocks on the dead process, but... we'll fix these all-up at some point in the future. |
I figured that much. Both my installs are unzip-only so I think they use the same ini file, namely C:\Users\vefatica\AppData\Local\Microsoft\Windows Terminal\settings.json. But a crash is a rather harsh reaction to a bad spec in an ini file. Can't (at least some) settings errors be overlooked and the file used anyway? |
|
Am I crazy? There doesn't seem to be anything of value in that dump:
Like, a single WinUI stack frame and nothing else, I'm not even sure how to start investigating that. @vefatica Do you have more consistent repro steps? |
Huh? It's pretty consistent. With this
1.11 gives the "failed to load settings" message (doesn't know about "down"), runs with a default set-up, and generates a dump upon exit. Here's one from today. If it doesn't look like there's anything wrong then I suppose the dump shouldn't have been generated. |
WILD. Last week when I looked at the dump, it looked totally corrupted. This week, there's an actual stack in it, an exception, things we can use!
Looks like the underlying crash is MSFT:26130824, which is fixed in Windows 11. Based on the fairly low number of hist and the fact that the crash is only once the app is already exiting, I don't think we'll be able to get that one serviced 😕 Thanks for reporting anyways! |
Hi! We've identified this issue as a duplicate of one that exists on somebody else's Issue Tracker. Please make sure you subscribe to the referenced external issue for future updates. Thanks for your report! |
Could be a dup; I didn't search. I usually run the preview release. When I start the most recent "stable" release, I get this.
When I dismiss it, I get a rather plain WT running Powershell. When I exit Powershell I get one of these.
WindowsTerminal.exe.520.dmp.zip
The text was updated successfully, but these errors were encountered: