Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Active/passive tab contrast is very low by default #1301

Closed
mikemaccana opened this issue Jun 17, 2019 · 1 comment
Closed

Active/passive tab contrast is very low by default #1301

mikemaccana opened this issue Jun 17, 2019 · 1 comment
Labels
Needs-Tag-Fix Doesn't match tag requirements Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing.

Comments

@mikemaccana
Copy link
Contributor

mikemaccana commented Jun 17, 2019 •
edited
Loading

Using today's git master:

image

The contrast between the advice and passive tabs is very low which makes it hard to find the active tab. Compare to Edge insiders:

image

Fluent Terminal is a UWP app that does a good job, using the accent color from the Windows UI:

image
@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Jun 17, 2019
@mikemaccana mikemaccana changed the title Active/passive contrast is very low by default Active/passive tab contrast is very low by default Jun 17, 2019
@zadjii-msft
Copy link
Member

Didn't you file the exact same issue in #771?

@zadjii-msft zadjii-msft added the Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing. label Jun 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Needs-Tag-Fix Doesn't match tag requirements Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mikemaccana @zadjii-msft