Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Double-click selection in vim doesn't wrap onto next line (although Terminal understands it's a single line because it detects and underscores the URL) #14263

Closed
vadimkantorov opened this issue Oct 20, 2022 · 8 comments
Labels
Issue-Bug It either shouldn't be doing this or needs an investigation. Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing.

Comments

@vadimkantorov
Copy link

vadimkantorov commented Oct 20, 2022

Windows Terminal version

1.15.2713.0 (btw would be nice if wt -v dialog window allowed copy of text)

Windows build number

10.0.22621.674

Other Software

No response

Steps to reproduce

Have a long line (url) in vim wrapping on multiple lines. It gets highlighted/underscored as a URL, so Terminal understands that it's a single line. But double-click for select/copy-on-select doesn't wrap around.

image

Expected Behavior

No response

Actual Behavior

Not the full line is selected

@vadimkantorov vadimkantorov added Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting labels Oct 20, 2022
@vadimkantorov vadimkantorov changed the title Double-click selection in vim doesn't wrap onto next line Double-click selection in vim doesn't wrap onto next line (although Terminal understands it's a single line) Oct 20, 2022
@lhecker
Copy link
Member

lhecker commented Oct 20, 2022

I believe this is a /duplicate of #6178.

@ghost
Copy link

ghost commented Oct 20, 2022

Hi! We've identified this issue as a duplicate of another one that already exists on this Issue Tracker. This specific instance is being closed in favor of tracking the concern over on the referenced thread. Thanks for your report!

@ghost ghost closed this as completed Oct 20, 2022
@ghost ghost added Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing. and removed Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting labels Oct 20, 2022
@DHowett
Copy link
Member

DHowett commented Oct 20, 2022

This may be like the bash issue, though, if vim is hard-wrapping its text. The URL detector strings together every line (which is also a problem, but in the other direction: it ignores hard wraps)!

@DHowett
Copy link
Member

DHowett commented Oct 20, 2022

btw would be nice if wt -v dialog window allowed copy of text

Funny enough, it does! All win32 dialogs/message boxes can be copied to the clipboard with Ctrl+C! They even get a fun hard copy rendition:

---------------------------
Help
---------------------------
Windows Terminal Preview
1.17.2842.0
---------------------------
OK   
---------------------------

@vadimkantorov
Copy link
Author

vadimkantorov commented Oct 20, 2022

Funny enough, it does!

Wow! It probably should be explicitly added to a dialog window title or window text. I bet that no more than 1000 people on the globe know about this win32 feature :) Or maybe OK could copy this text to the clipboard as well (but this would also need to be hinted)

@vadimkantorov
Copy link
Author

This may be like the bash issue, though, if vim is hard-wrapping its text.

Bash can interfere into vim? My problem was specifically with vim.

But bash seems to have the same problem:
image

@DHowett
Copy link
Member

DHowett commented Oct 20, 2022

Bash can interfere into vim?

Sorry, what I mean is this.

bash does hard line wrapping.
Maybe vim does hard line wrapping too.

(It may be "like" the bash issue you'd filed. 🙂)

@vadimkantorov vadimkantorov changed the title Double-click selection in vim doesn't wrap onto next line (although Terminal understands it's a single line) Double-click selection in vim doesn't wrap onto next line (although Terminal understands it's a single line because it detects and underscores the URL) Oct 20, 2022
@vadimkantorov
Copy link
Author

Maybe at least for the case of URLs, the hard-wrap merging could be enabled... it's very strange that uncerscoring and selection do not match

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Issue-Bug It either shouldn't be doing this or needs an investigation. Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing.
Projects
None yet
Development

No branches or pull requests

3 participants