Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Open in Terminal" to start in existing terminal instances by default? #14347

Closed
vadimkantorov opened this issue Nov 5, 2022 · 6 comments
Closed
Labels
Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing.

Comments

@vadimkantorov
Copy link

vadimkantorov commented Nov 5, 2022

Right now, it always spawns a new Terminal instance / window which can be a tad slower than just spawning a new tab in existing instance. This can be compared as opening an HTML file from disk which usually would open it in existing Chrome instances and just open a new tab.

Propose to have a discussion to have the same behavior for Terminal by default (great that an option already exists in the config though! thanks to @237dmitry for pointing it out!)

@vadimkantorov vadimkantorov added the Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. label Nov 5, 2022
@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Nov 5, 2022
@237dmitry
Copy link

This option already exists

"windowingBehavior": "useAnyExisting"

@vadimkantorov
Copy link
Author

thank you! great to know! i'll then repurpose this issue to propose to make it default

@vadimkantorov vadimkantorov changed the title Option to allow starting "Open in Terminal" in existing terminal instances "Open in Terminal" to start in existing terminal instances by default? Nov 5, 2022
@zadjii-msft
Copy link
Member

Thanks for the suggestion! Until we've got tab tear-out sorted out, I've been reluctant to change any defaults to useExisting. That would just make the windows glom together and now you'd be stuck without it being able to tear into it's own window. Trust when I say, when tear-out is ready for stable releases, we'll be changing the default to useExisting.

There's also /dup #7071 for adding a separate setting to control the shell context menu's behavior separate from the globals, but that's quite a bit farther out.

@zadjii-msft zadjii-msft closed this as not planned Won't fix, can't repro, duplicate, stale Nov 7, 2022
@ghost
Copy link

ghost commented Nov 7, 2022

Hi! We've identified this issue as a duplicate of another one that already exists on this Issue Tracker. This specific instance is being closed in favor of tracking the concern over on the referenced thread. Thanks for your report!

@ghost ghost closed this as completed Nov 7, 2022
@ghost ghost added Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing. and removed Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Nov 7, 2022
@vadimkantorov
Copy link
Author

One nuance, in Chrome it would use last active window for opening disk files, not just "any existing window"

@zadjii-msft
Copy link
Member

One nuance, in Chrome it would use last active window for opening disk files, not just "any existing window"

That's literally exactly what useExisting does

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing.
Projects
None yet
Development

No branches or pull requests

3 participants