Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.18] Defterm was only busted on my machine #15238

Closed
zadjii-msft opened this issue Apr 26, 2023 · 2 comments
Closed

[1.18] Defterm was only busted on my machine #15238

zadjii-msft opened this issue Apr 26, 2023 · 2 comments
Assignees
Labels
Area-DefApp Needs-Tag-Fix Doesn't match tag requirements Product-Terminal The new Windows Terminal. Severity-Blocking We won't ship a release like this! No-siree.

Comments

@zadjii-msft
Copy link
Member

zadjii-msft commented Apr 26, 2023

Handoff fails, and then we open an empty terminal window (yknow, the kind with 0 tabs).

Repros back to at least 52171d2

Attempted bisect
  • 2e3d5e6 (HEAD -> main, origin/main) Rewrite AtlasEngine to allow arbitrary overhangs
  • 405fb51 Fix AppInitialized latency metric
  • e413a41 Prevent crash when VTParameters::subspan is out of range
  • 4ebc383 A hypothetical fix for hidden windows
  • fea6eed Disable the context menu command inside a zipped folder
  • adbe4a0 Fix missing call to UpdateViewport::UpdateViewport during tearout
  • 7e9f09f A very sensible Pane refactoring
  • 06dc975 Switch to function pointers
  • def3742 Fix focus issue when profile selected from nested menu entry
  • 5ed3c76 Remove IsUwp, RunAsUwp, defaults-universal and all fallout
  • e491141 Remove the window thread from the list of threads before nulling the AppHost
  • 0d1540b Add buttons for selecting commands, output to context menu
  • 2cfd73d Enable WINRT_LEAN_AND_MEAN
  • ee05307 Also do the VisualState dance on the tab item
  • 4788347 Make sure the command palette isn't null
  • 210414e (origin/1.17) Default to XamlRoot when unable to find focused object
  • 2aefb30 Remove a 1px gap under the tabs only visible at >150%
  • ffda8c4 Add automation heading level 1 to fix about dialog
  • 2fd33ba unpackaged: allow building an unpackaged distribution from layout
  • 2c16543 Add a warning when a proportional font is selected
  • 0e86ce5 Add the ability to select a whole command (or its output)
  • 35b9e75 Avoid animations during startup
  • da0a6d4 Lazy load CommandPalette and AboutDialog
  • c2dd614 Fix Peasant::ActivateWindow being called with an all 0 GUID
  • 27bcf7e Add subtext to why Always show tabs is not toggleable in SUI.
  • 2c16e7c Respect the startup info state initially passed to wt via ShellExecute
  • 1825ca1 fix not updating the nav view when add/removing profiles
  • e106c09 Enable ctrl+shift to run terminal elevated from context menu
  • 52171d2 Update to MUX 2.8.3
  • 9b960bc Fix reordering tabs mysteriously shuffling the actual backing tabs
  • 1d354d0 Fix a hang when writing wide glyphs into a 1 column terminal
  • eb725e9 fix: WpfTerminalControl allow Connection set to null
  • 19069e0 A more efficient copy assignment operator for Pane.LayoutSizeNode
  • ❔ (👀) 21464fe Manually hide our DesktopWindowXamlSource
  • 789b0b0 Actually use the persisted position with centerOnLaunch:true
  • 72d0566 (dev/migrie/b/mux-2.8.l3) Back off between attempts to start the tests
  • f671f06 Register the GetWindowLayoutRequested handler only when ready
  • 10bdadf Skip generating a profile for rancher-desktop
  • 56d451d Support environment variables in the settings
  • 508adbb Send a KeyUp sequence only once a key has been released
  • b4f6503 Fix re-persisting the new legacy themes
  • 90bbd29 Helix: Decode HTML entities in the test comment fiel
  • ea44375 Check for updates automatically (but don't install)
  • 7fbd3be Only try to hand off to ConhostV1 if building for Windows
  • de09671 wpf: Bump the history length to 9001 instead of 1000
  • c7498a4 PGO: Update the Helix payload to rely on the unpackaged distribution
  • 083fc64 Revert the revert of "Hide the window until we're finished with initialization"
  • 6f8ef58 Add support for running the Terminal without any windows
  • fe66ba5 Add "legacy" themes
  • e73362d Respect the codepage stored in .LNK files in conhost
  • a98a0cf Stop the beef when you hover off a hyperlink
  • 5db8af6 Return success if ReadCharacterInput read >0 characters
  • 5f70920 When unpackaged, isolate the monarch by the install path
  • 6244896 Upgrade clang-format to 15.0.7
  • ecb5e37 Use new row primitives for ResizeTraditional
  • aea0477 Filter out control characters that don't do anything
  • 06526ca Remove our dependency on any CRT--AppX or forwarders
  • 9dfdf2a Introduce til::linear_flat_set
  • 2a839d8 Fix accuracy bugs around float/double/int conversions
  • da995a0 Enable holding ctrl to open the Terminal elevated from Fil
  • 47a17cf Replace statics in headers with inline constants
  • c0f1456 Use DIPs for the window bounds when tearing out
  • 5de1fd9 Introduce til::generational - a struct comparison helper
  • 17cf44f Upgrade to MUX 2.8
  • 06174a9 Format URLs for display when we show the tooltip
  • 0656afc Expose hyperlink attributes in PaintBufferGridLines
  • 0d38d17 Add a simple tool to test rendering functionality
  • 7ddd98d Fix warnings in til for an upcoming version of MSVC
  • 0105807 Add pre-build PowerShell version check
  • e6a3fa8 Add "portable mode", where settings load from the install path
  • bbd4d1b Fix a crash in the rclick context menu
  • 984b03c [SPEC] Add a lightweight spec for Portable Mode
  • 7b0aca4 Enable tearing out tabs to create new windows
  • dd63a05 Add support for an unpackaged distribution of Terminal
  • fc95802 Merge the LineFeed functionality into AdaptDispatch
  • da3a33f Minor cleanups after Remove TranslateUnicodeToOem and all related code #14745
  • 9514c11 Enable dragging tabs between windows
  • 17a5b77 Add support for moving panes and tabs between windows
  • 34aa6aa Update DECSC/DECRC to match the newer DEC terminals
  • c7816fd Add flexible virtualization rules for HKCU\Console\Startup
  • d9efdae Fix font size of HTML clipboard contents
  • c4d0298 Add a second way of detecting whether DefTerm is available
  • f20cd3a Add an efficient text stream write function
  • f5e9e8e Consolidate our MSIX distribution back down to one package

OKAY I think this has got to be something unique to my machine.

@microsoft-github-policy-service microsoft-github-policy-service bot added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Apr 26, 2023
@zadjii-msft zadjii-msft self-assigned this Apr 26, 2023
@zadjii-msft zadjii-msft added Product-Terminal The new Windows Terminal. Severity-Blocking We won't ship a release like this! No-siree. Area-DefApp and removed Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting labels Apr 26, 2023
@zadjii-msft zadjii-msft added this to the Terminal v1.18 milestone Apr 26, 2023
@zadjii-msft zadjii-msft changed the title [1.18] Defterm is busted [1.18] Defterm was only busted on my machine Apr 26, 2023
@zadjii-msft
Copy link
Member Author

Guys I can't explain it, but I

  • closed all terminal instances (dev, preview and stable)
  • did a del /s *openconsoleproxy.*
  • re-deployed the Terminal

and it's working again. Sorry for the fire drill 🙃

@zadjii-msft zadjii-msft closed this as not planned Won't fix, can't repro, duplicate, stale Apr 26, 2023
@zadjii-msft
Copy link
Member Author

Or, more correctly, it explodes whenever I'm debugging with VS? Whatever.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-DefApp Needs-Tag-Fix Doesn't match tag requirements Product-Terminal The new Windows Terminal. Severity-Blocking We won't ship a release like this! No-siree.
Projects
None yet
Development

No branches or pull requests

1 participant