Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Paste doesn't always work as expected in broadcasted panes #16287

Open
Tracked by #15812
stevelipinski opened this issue Nov 10, 2023 · 7 comments
Open
Tracked by #15812

Paste doesn't always work as expected in broadcasted panes #16287

stevelipinski opened this issue Nov 10, 2023 · 7 comments
Assignees
Labels
Area-TerminalControl Issues pertaining to the terminal control (input, selection, keybindings, mouse interaction, etc.) Area-User Interface Issues pertaining to the user interface of the Console or Terminal Help Wanted We encourage anyone to jump in on these. Issue-Bug It either shouldn't be doing this or needs an investigation. Product-Terminal The new Windows Terminal.
Milestone

Comments

@stevelipinski
Copy link

The pane broadcast functionality that's currently in preview does not describe nor allow to configure how paste functionality works.
Currently, if you paste into a broadcast group of panes using right-click, it only pastes in the pane that the mouse is hovering over.
On the other hand, if you paste using Ctrl-v, it inconsistently pastes into some of the broadcast group panes - but usually not all.

It would be nice if there was a configuration option that specified how to handle paste with a broadcast group.
And, the Ctrl-v paste should be consistent and either configurable or follow the same behavior as right-click.

@stevelipinski stevelipinski added the Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. label Nov 10, 2023
@microsoft-github-policy-service microsoft-github-policy-service bot added Needs-Tag-Fix Doesn't match tag requirements Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting labels Nov 10, 2023
@zadjii-msft
Copy link
Member

This sorta sounds a bit like the last bullet point I had tracked in #15812

Broadcast doesn't work if you use context menu paste

That's a bit different - the right-click context menu uses the same paste mechanism as the normal right-click-to-paste. So that should act the same. But then you go and mention:

On the other hand, if you paste using Ctrl-v, it inconsistently pastes into some of the broadcast group panes - but usually not all

And that, I don't think we had tracked anywhere. We can probably use this to track both issues (I'd bet they have the same resolution). Could you elaborate more on the "aCtrl+V paste doesn't work" scenario more? I don't think we've got a solid repro for that...

@zadjii-msft zadjii-msft added Help Wanted We encourage anyone to jump in on these. Issue-Bug It either shouldn't be doing this or needs an investigation. Area-User Interface Issues pertaining to the user interface of the Console or Terminal Area-TerminalControl Issues pertaining to the terminal control (input, selection, keybindings, mouse interaction, etc.) Product-Terminal The new Windows Terminal. and removed Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. labels Nov 10, 2023
@zadjii-msft zadjii-msft added this to the Terminal v1.20 milestone Nov 10, 2023
@microsoft-github-policy-service microsoft-github-policy-service bot removed the Needs-Tag-Fix Doesn't match tag requirements label Nov 10, 2023
@zadjii-msft zadjii-msft changed the title Paste in broadcasted panes Paste doesn't always work as expected in broadcasted panes Nov 10, 2023
@stevelipinski
Copy link
Author

stevelipinski commented Nov 10, 2023

I use Rocky (RedHat) Linux in WSL, so that's my use case for Terminal (if that has any relevance - I dunno).

If I open 3 panes (1, 2, 3, top-bottom), enable broadcast.
Pressing Ctrl-V with 'foo' in the clipboard, multiple times does the following on the iterations:

  • pastes in 1&2
  • pastes in 1&2
  • pastes in 1&2&3
  • pastes in 2&3
  • pastes in 3
  • pastes in 1&3
  • ...

AFAICT the delay between keystrokes does not seem to alter. fast or delay between - it is behaves inconsistently regardless.

@carlos-zamora carlos-zamora removed the Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting label Nov 15, 2023
@github-project-automation github-project-automation bot moved this to To Cherry Pick in 1.19 Servicing Pipeline Aug 27, 2024
@zadjii-msft
Copy link
Member

other notes to self in #15812 (comment)

@zadjii-msft zadjii-msft modified the milestones: Terminal v1.21, Backlog Sep 4, 2024
@MateuszBeru
Copy link

MateuszBeru commented Dec 10, 2024

Problem still persist and it's crashing whole Windows Terminal [1.21.321.0].
While using Toggle Broadcast Input To All Panes and trying to paste you can experience such behaviors:
-Right-Click as Paste: pasting in only 1 pane (active)
-Ctrl+V as paste: pasting in random panes, missing 1st one and pasting in rest of them or in random pattern
-Ctrl+Shift+V as paste: even more random panes, sometimes sticking to only two-three panes and randomly pasting to other
-Pasting few times with Key-Combo (Ctrl+V/Ctrl+Shift+V) will crash whole Windows Terminal

Last one is super annoying when user is connected to multiple SSH sessions and it is in the middle of editing file or command chain.

To be honest whole Broadcast Input in Windows Terminal is a gimmick than actual helpful plugin, and once user will face such problems it quit using it straight away.

Our team basically was hyped for this functionality, after first such broken experience we jumped back to our rather complicated, yet more stable option I can recommend

install WSL
install tmux
use "setw synchronize-panes on"
no problem with pasting and you can save sessions

I would love to see fully working Broadcast Input functionality working on Windows Terminal

@stevelipinski
Copy link
Author

stevelipinski commented Dec 10, 2024

I'm using Terminal Preview, v1.22.3232.0 , and I cannot get it to crash under any circumstance of Ctrl-v/Shift-Ctrl-v.

@MateuszBeru
Copy link

MateuszBeru commented Dec 10, 2024

@stevelipinski Example: pasting snippet of 20 characters with hold on CTRL+V(+Shift) will crash it.
I can't crash Wterm on hold Ctrl-V(+Shift) when not using panes and not using broadcast input.

See Attached video
Image

@stevelipinski
Copy link
Author

ah, ok - I can confirm - holding it down does crash it in Preview as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-TerminalControl Issues pertaining to the terminal control (input, selection, keybindings, mouse interaction, etc.) Area-User Interface Issues pertaining to the user interface of the Console or Terminal Help Wanted We encourage anyone to jump in on these. Issue-Bug It either shouldn't be doing this or needs an investigation. Product-Terminal The new Windows Terminal.
Projects
Status: To Cherry Pick
Development

No branches or pull requests

4 participants