VT mouse sequences don't work when DECARM is disabled #16510
Labels
Area-VT
Virtual Terminal sequence support
Help Wanted
We encourage anyone to jump in on these.
In-PR
This issue has a related PR
Issue-Bug
It either shouldn't be doing this or needs an investigation.
Needs-Tag-Fix
Doesn't match tag requirements
Product-Conhost
For issues in the Console codebase
Windows Terminal version
1.19.3172.0
Windows build number
10.0.19045.3803
Other Software
Vttest
Steps to reproduce
vttest
.Expected Behavior
You should see the mouse escape sequence starting with
<27> [ M <32>
output near the top of the page, and a1
output wherever you've clicked.Actual Behavior
Some of the characters in the mouse sequence are lost, so it starts with
<27> <32>
, and there is nothing output in the cell where you've clicked.This is similar to the problem we had with the Device Attribute reports not working in vttest because it disables auto-repeat mode (#14208). But in this case the lost key events are coming from conpty passing the mouse sequences through
TerminalInput::HandleKey
, so it only affects Windows Terminal.The fact that the mouse sequences are being treated as keypresses is already questionable, and I think that's likely the cause of #15083, but I also think
HandleKey
should be capable of accepting a sequence of key events with a0
virtual key (as a form of input "passthrough"), withoutDECARM
getting in the way.So my proposed solution is this: before we even check for repeated keys, if we receive a key-down event, and the virtual key code is
0
orVK_PACKET
(which serves a similar purpose), then we should immediately return the givenUnicodeChar
value as theHandleKey
output.The text was updated successfully, but these errors were encountered: