Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tab characater rendering doesn't align well. #16556

Closed
yslib opened this issue Jan 13, 2024 · 2 comments
Closed

Tab characater rendering doesn't align well. #16556

yslib opened this issue Jan 13, 2024 · 2 comments
Labels
Issue-Bug It either shouldn't be doing this or needs an investigation. Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing.

Comments

@yslib
Copy link

yslib commented Jan 13, 2024

Windows Terminal version

1.18.3181.0

Windows build number

10.0.23612.1000

Other Software

ArchWSL
Oh-My-Zsh Configure
Hack Nerd Font

Steps to reproduce

Rendering some nerd glyphs or tab characters in WT. Both in default text engine and AtlasEngine

Expected Behavior

These Hack Nerd Font glyph should be aligned in any scaling.

Actual Behavior

When using small zooming scale in Windows Terminal, the corner tab character appears in the panel border (ohmyzsh powerline10k prompt, lazygit panel or neovim panel) seems not aligned well compared to the same glyph rendering in Alacritty.

At small scaling
image
image

But at relatively large scaling, it's ok
image

In Alacritty, the same glyph works well for any scaling
image
image
image

The p10k theme prompt rendering in alacritty is better than it in WT, but it still not as perfect as it in real Linux.

@yslib yslib added Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting labels Jan 13, 2024
@yslib yslib changed the title some tab characater rending not aligment some tab characater rendering not aligment Jan 13, 2024
@yslib yslib changed the title some tab characater rendering not aligment Tab characater rendering doen't align well. Jan 13, 2024
@yslib yslib changed the title Tab characater rendering doen't align well. Tab characater rendering doesn't align well. Jan 13, 2024
@lhecker
Copy link
Member

lhecker commented Jan 15, 2024

Thanks for the report! We're already aware about this issue and are tracking it here: #5897
We haven't gotten to addressing it yet unfortunately. 😓 The shift at smaller sizes occurs due to hinting (to make the font crispier when it doesn't perfectly align with the pixels). Fixing it requires drawing our own custom box drawing glyphs.

/dup #5897

Copy link
Contributor

Hi! We've identified this issue as a duplicate of another one that already exists on this Issue Tracker. This specific instance is being closed in favor of tracking the concern over on the referenced thread. Thanks for your report!

@microsoft-github-policy-service microsoft-github-policy-service bot added Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing. and removed Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting labels Jan 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Issue-Bug It either shouldn't be doing this or needs an investigation. Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing.
Projects
None yet
Development

No branches or pull requests

2 participants