-
Notifications
You must be signed in to change notification settings - Fork 8.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Freeze & crash Windows Terminal Preview 1.21.1272.0 with these few simple steps, you'll never guess what the 3rd one is! #17202
Comments
This comment has been minimized.
This comment has been minimized.
Dr. Watson as the grimmest reaper. I love it. Would you be able to file feedback and reproduce the crash in the Apps > Terminal node and share the link with us? I can't get this to happen locally . . . and I want to see if it's the same bug we just fixed with #17199. |
Feedback Hub: https://aka.ms/AAqbvpz |
I can get it to freeze every single time on a Surface Book 2 15", but cannot reproduce on an Intel NUC (NUC13ANKI50WC). Could it be something GPU-related? The Surface Book 2 has always been a bit unreliable, even Edge sometimes restarts its rendering engine. |
I'm seeing a thread tearing down a Watson cab |
It's really weird, I could narrow it down to showing the appearance page for any shell, not necessarily the one being used in the other window. So it has to be the settings page that is tore off to create a new window, and it has to show the appearance with the preview. You can navigate to another setting page again, as long as the preview has been displayed, it will crash. Is there some Atlas resources that are shared with the preview and may be freed when Settings is closed? Why would it only happen when the settings is tore off? It is pretty easy to avoid the bug, and I cannot reproduce it on another system, so it's not a blocking issue by any means, but I feel like there must be some underlying issue that just happens to get less noticeable on other systems. |
Attached another crash dump to the Feedback Hub report. |
try to disable "Shell handwriting" option in Windows Settings... |
@scc23456 Good catch! So there seems to be a problem between Terminal and "write anywhere", and this shows why it is important to try to test software on some devices with 👆 touch and 🖊️ pen, not only on typical workstations. |
Yeah, it's a recent feature the shell team introduced to write directly in many common controls. For example we can ink directly inside a textbox or address bar using the pen. This is intended to be a faster way to input text without having to display the tablet input panel (TabTip). I suspect you're using or subclassing some common control, the shell attaches some overlay inking panel on top of it, and you destroy it without going through the original code that ensures the attached inking panel is properly disposed of, then it crashes when trying to access its parent HWND or something. This is just a wild guess though, I haven't checked how they implemented the Ink Anywere feature yet. |
@lhecker Are you giving up on this one? I didn't see any similar crash with that feature in other apps, there is probably something Terminal does that makes it crash when that feature extends its controls. |
Please don't read too much into how we manage our issue assignments. 😅 |
Good news! We couldn't reproduce this because it's fixed in Windows 11 Build 26100 (24H2 release). It still reproduces in the previous release. Tracking - MSFT:46832480 |
Windows Terminal version
1.21.1272.0
Windows build number
10.0.22631.3527 x64
Other Software
Just Terminal Preview, crashes with any shell (tested cmd.exe, bash in Ubuntu in WSL2).
Steps to reproduce
[v]
menu, and select Settings to display the settings page[Appearance >]
I've crashed it 10 times using these steps, it works every single time.
Edit: I'm still trying to reduce the steps to the minimum required.
Expected Behavior
Windows Terminal should keep running
Actual Behavior
Windows Terminal freezes, its client area gets ghosty transparent, it receives the dreaded
(Not Responding)
suffix, and Dr. Watson comes along to put it out if its misery.The text was updated successfully, but these errors were encountered: