Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

We need to actually fix our UpdateWhileInUse manifest (was: Terminal closes itself unexpectedly from time to time) #18119

Closed
ygoe opened this issue Oct 28, 2024 · 7 comments · Fixed by #18252
Labels
Area-Build Issues pertaining to the build system, CI, infrastructure, meta In-PR This issue has a related PR Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Tag-Fix Doesn't match tag requirements Product-Terminal The new Windows Terminal.

Comments

@ygoe
Copy link

ygoe commented Oct 28, 2024

Windows Terminal version

1.21.2911.0

Windows build number

10.0.22631.3880

Other Software

No response

Steps to reproduce

  1. Start the terminal app
  2. Let it run with one or two tabs open running console applications

Expected Behavior

Terminal should stay open until I close it.

Actual Behavior

Terminal closes itself from time to time, also stopping all running console applications. Last time was last night at 2024-10-28 01:50 +0100. I have no event log of this but it could be once in a few months. All other applications are still running, nothing else stops unexpectedly.

@ygoe ygoe added Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting labels Oct 28, 2024
Copy link

We've found some similar issues:

If any of the above are duplicates, please consider closing this issue out and adding additional context in the original issue.

Note: You can give me feedback by 👍 or 👎 this comment.

@ygoe
Copy link
Author

ygoe commented Oct 28, 2024

If it's an auto-update situation and the Store app force-closes the Terminal, then there's a serious problem here. The Store must not have the power to randomly kill other apps whenever it wants. If that's what it does, I'll have to force-disable those updates. I expect it to be at least so cooperative and inform me that it wants to install an update and requires the Terminal to close. If I can't afford to stop all currently running console apps (which might do long-running work), I must have the ability to defer this for arbitrary time.

I'd appreciate it doing its updates when I also let Windows Update run. Then I'm aware that a reboot is needed and all apps are closed, so I'll only do that when possible. IIRC, PowerShell (the new one) is also only updated along with Windows Updates, so Terminal should do just the same.

@zadjii-msft zadjii-msft changed the title Terminal closes itself unexpectedly from time to time We need to actually fix our UpdateInUse manifest (was: Terminal closes itself unexpectedly from time to time) Oct 28, 2024
@zadjii-msft zadjii-msft added the Product-Terminal The new Windows Terminal. label Oct 28, 2024
@zadjii-msft zadjii-msft changed the title We need to actually fix our UpdateInUse manifest (was: Terminal closes itself unexpectedly from time to time) We need to actually fix our UpdateWhileInUse manifest (was: Terminal closes itself unexpectedly from time to time) Oct 28, 2024
@zadjii-msft
Copy link
Member

zadjii-msft commented Oct 28, 2024

Alas, this actually came up in a mail thread while I was out. For my own reference: "Subject: RE: UpdateWhileInUse issue follow-up"

tldr of that thread is that we didn't update our manifest entirely correctly. Sounds like just adding the new property (<uap17:UpdateWhileInUse>defer</>) wasn't good enough. We'll also need to set our MaxVersionTested to 10.0.26100.0.

This alas will have other, unexpected consequences (apparently), so we will need to do quite a bit of validation on our side.

(originally presumed fixed in #16250)

@zadjii-msft zadjii-msft added this to the Terminal v1.23 milestone Oct 28, 2024
@zadjii-msft zadjii-msft added the Area-Build Issues pertaining to the build system, CI, infrastructure, meta label Oct 28, 2024
@ygoe
Copy link
Author

ygoe commented Oct 28, 2024

Good to hear that you know what's happening and what might fix it.

Until this is fixed, can I selectively prevent Terminal from being updated automatically? Without disabling all app updates altogether? Or can I only shut down the whole thing all at once? I remember Android has auto-update settings per app (not that auto-update would actually reliably do anything there, but at least the option is there). Couldn't find that in Windows or the Store app now.

@carlos-zamora carlos-zamora removed the Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting label Oct 30, 2024
@hammypants
Copy link

Still happening.

Until this is fixed, can I selectively prevent Terminal from being updated automatically? Without disabling all app updates altogether? Or can I only shut down the whole thing all at once? I remember Android has auto-update settings per app (not that auto-update would actually reliably do anything there, but at least the option is there). Couldn't find that in Windows or the Store app now.

I would also like to know this.

@ygoe
Copy link
Author

ygoe commented Nov 25, 2024

No info yet. I've disabled the automatic updates in Windows Store. Like I already did for Windows altogether. Considering Microsoft's ever-decreasing updates quality, extra carefulness is due. Never let it update when it wants to interrupt your work. Do it shortly before new updates appear. By then most issues should be sorted out.

@zadjii-msft
Copy link
Member

Alas, not that I'm aware of. This has been one of rougher edges with the Store as long as I can remember. Updating our manifest is the only way I know how to fix this. Just a bummer that the magic keyword here needed a second magic keyword that we didn't know about, and has other possibly unexpected consequences 😕

@microsoft-github-policy-service microsoft-github-policy-service bot added the In-PR This issue has a related PR label Nov 27, 2024
@DHowett DHowett closed this as completed in 32eeefd Dec 3, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added Needs-Tag-Fix Doesn't match tag requirements labels Dec 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Build Issues pertaining to the build system, CI, infrastructure, meta In-PR This issue has a related PR Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Tag-Fix Doesn't match tag requirements Product-Terminal The new Windows Terminal.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants