Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resolve longstanding issues with conhost's MeasureRight #2089

Closed
BladeMF opened this issue Jul 25, 2019 · 5 comments
Closed

Resolve longstanding issues with conhost's MeasureRight #2089

BladeMF opened this issue Jul 25, 2019 · 5 comments
Assignees
@miniksa
Labels
Area-Output Related to output processing (inserting text into buffer, retrieving buffer text, etc.) Issue-Task It's a feature request, but it doesn't really need a major design. Needs-Tag-Fix Doesn't match tag requirements Product-Conhost For issues in the Console codebase Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing.

Comments

@BladeMF
Copy link

BladeMF commented Jul 25, 2019

Environment

Windows build number: Version 10.0.18362.239
Windows Terminal version (if applicable):0.2.1831.0

Symfony 4.3

Steps to reproduce

Render a block with background color after the text. The used command is from Symfony 4.3. I can provide instructions or find the exact control codes that were used if needed.

Expected behavior

A solid block of background color. The screenshot is from cmd.

image

Actual behavior

The background color ends after the text.

image
@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Jul 25, 2019
@DHowett-MSFT
Copy link
Contributor

Congrats, this is now the "Kill MeasureRight" (it'll make sense later) issue. The heart of the issue is that conhost can occasionally not tell whether the spaces that are in the buffer were on purpose or not. 🤷‍♀

@DHowett-MSFT DHowett-MSFT changed the title Block with background color not rendered after text Resolve longstanding issues with conhost's MeasureRight Jul 29, 2019
@DHowett-MSFT DHowett-MSFT added Area-Output Related to output processing (inserting text into buffer, retrieving buffer text, etc.) Issue-Task It's a feature request, but it doesn't really need a major design. Product-Conhost For issues in the Console codebase and removed Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting labels Jul 29, 2019
@ghost ghost removed the Needs-Tag-Fix Doesn't match tag requirements label Jul 29, 2019
@DHowett-MSFT DHowett-MSFT added this to the Console Backlog milestone Jul 29, 2019
@BladeMF
Copy link
Author

BladeMF commented Aug 6, 2019

More examples (hopefuly useful):
image
See how "Success!" is OK, but "Application Migration" isn't? Not sure what that means.

@DHowett-MSFT DHowett-MSFT mentioned this issue Aug 14, 2019
Closed
@DHowett-MSFT DHowett-MSFT mentioned this issue Oct 6, 2019
Closed
@DHowett-MSFT DHowett-MSFT mentioned this issue Oct 29, 2019
Closed
@DHowett-MSFT DHowett-MSFT mentioned this issue Feb 6, 2020
Closed
@DHowett-MSFT
Copy link
Contributor

I hacked at making MeasureRight care about attributes, and while it was slow it felt like it did the right thing.

@Jyrka98 Jyrka98 mentioned this issue Mar 17, 2020
Closed
@DHowett DHowett mentioned this issue Jun 12, 2020
Closed
@DHowett DHowett mentioned this issue Apr 13, 2021
Closed
@zadjii-msft
Copy link
Member

Huh, this is /dup #32, and more broadly, we're tracking this in #8000.

@zadjii-msft zadjii-msft removed this from the Console Backlog milestone Dec 6, 2021
@ghost
Copy link

ghost commented Dec 6, 2021

Hi! We've identified this issue as a duplicate of another one that already exists on this Issue Tracker. This specific instance is being closed in favor of tracking the concern over on the referenced thread. Thanks for your report!

@ghost ghost closed this as completed Dec 6, 2021
@ghost ghost added Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing. Needs-Tag-Fix Doesn't match tag requirements labels Dec 6, 2021
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@miniksa miniksa

Labels
Area-Output Related to output processing (inserting text into buffer, retrieving buffer text, etc.) Issue-Task It's a feature request, but it doesn't really need a major design. Needs-Tag-Fix Doesn't match tag requirements Product-Conhost For issues in the Console codebase Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@BladeMF @DHowett-MSFT @miniksa @zadjii-msft