Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't resize the terminal buffer until dragging is released #2140

Open
zadjii-msft opened this issue Jul 29, 2019 · 2 comments
Open

Don't resize the terminal buffer until dragging is released #2140

zadjii-msft opened this issue Jul 29, 2019 · 2 comments
Labels
Area-User Interface Issues pertaining to the user interface of the Console or Terminal Help Wanted We encourage anyone to jump in on these. Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. Product-Terminal The new Windows Terminal.
Milestone

Comments

@zadjii-msft
Copy link
Member

Add a setting to enable this behavior.

Maybe the user might not want to reflow the buffer in real-time as they resize the window. Maybe they only want to have the resize occur when they finish resizing.

I'd love to see an E2E spec of this scenario before code starts getting written, because I feel it might be a little wonky in certain scenarios. Questions that would be good to be answered:

  • How will we communicate the start of a move/size loop from WindowsTerminal down to the TerminalApp?
  • How will this play with panes that aren't terminals?
  • how do we handle maximize/restore?
  • Should we pause rendering while this is happening? How should this look to the user?

From discussion in #1465

@zadjii-msft zadjii-msft added Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. Help Wanted We encourage anyone to jump in on these. Area-User Interface Issues pertaining to the user interface of the Console or Terminal Product-Terminal The new Windows Terminal. labels Jul 29, 2019
@zadjii-msft zadjii-msft added this to the Terminal Backlog milestone Jul 29, 2019
@ghost ghost added the Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting label Jul 29, 2019
@miniksa
Copy link
Member

miniksa commented Jul 29, 2019

I thought this was already handled for us by the operating system in this option:
image

If that's off, the OS shouldn't be telling us the move/size messages until it is released.
If it's on, the OS tells us.

Are we saying that's not enough or that we need to override that further?

@zadjii-msft
Copy link
Member Author

Yea I think this is for a more refined feature on top of that. Since conpty does re-rendering on resizes, people might want to only have the terminal actually process the new buffer size at the end of the resize.

@DHowett-MSFT DHowett-MSFT removed the Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting label Jul 29, 2019
@zadjii-msft zadjii-msft modified the milestones: Terminal Backlog, Backlog Jan 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-User Interface Issues pertaining to the user interface of the Console or Terminal Help Wanted We encourage anyone to jump in on these. Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. Product-Terminal The new Windows Terminal.
Projects
None yet
Development

No branches or pull requests

3 participants