Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Add a Copy Profile command #2281

Closed
kfarmer-msft opened this issue Aug 6, 2019 · 4 comments
Closed

Feature Request: Add a Copy Profile command #2281

kfarmer-msft opened this issue Aug 6, 2019 · 4 comments
Labels
Area-Settings Issues related to settings and customizability, for console or terminal Area-UserInterface Issues pertaining to the user interface of the Console or Terminal Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Product-Terminal The new Windows Terminal. Resolution-Won't-Fix We're just really obstinate about this. There's probably a good reason.

Comments

@kfarmer-msft
Copy link

Description of the new feature/enhancement

Adds a command that, when executed, pops up a dialog with a field prompting for the name of a new profile, and another to edit the command (pre-populated with the command of the current profile?). On confirmation, the new profile is created and added to the end of the list, and persisted in profiles.json for later editting.

Other profiles options can be omitted. This is intended to be a quick "make a new profile using the settings of the current" command, without having to edit profiles.json.

Proposed technical implementation details (optional)

This may be part of the larger profiles.json editting feature, but I think it warrants a separate, simpler workflow than a larger editing experience leads to.

I think this would be a good pairing for #2046.

@kfarmer-msft kfarmer-msft added the Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. label Aug 6, 2019
@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Aug 6, 2019
@zadjii-msft
Copy link
Member

Frankly I think this is better suited under the umbrella of #1564

@kfarmer-msft
Copy link
Author

Agreed. My intent was "I think the feature would work well in conjunction with #2046" -- which I'm also a fan of.

@carlos-zamora carlos-zamora added Area-Settings Issues related to settings and customizability, for console or terminal Area-UserInterface Issues pertaining to the user interface of the Console or Terminal Product-Terminal The new Windows Terminal. and removed Needs-Tag-Fix Doesn't match tag requirements labels Aug 7, 2019
@DHowett-MSFT
Copy link
Contributor

This is an interesting one. I think that we should relegate these actions to the settings UI, but I can see some value in having this be a quick action. I dunno. I'm inclined to come down on the side of "let's have an easy button once we have buttons related to Settings".

@DHowett-MSFT
Copy link
Contributor

(If y'all disagree, we can definitely reopen.)

@DHowett-MSFT DHowett-MSFT added the Resolution-Won't-Fix We're just really obstinate about this. There's probably a good reason. label Aug 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Settings Issues related to settings and customizability, for console or terminal Area-UserInterface Issues pertaining to the user interface of the Console or Terminal Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Product-Terminal The new Windows Terminal. Resolution-Won't-Fix We're just really obstinate about this. There's probably a good reason.
Projects
None yet
Development

No branches or pull requests

4 participants