Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Console Find dialog should remember last-searched-for string #2844

Closed
asklar opened this issue Sep 22, 2019 · 0 comments · Fixed by #2845
Closed

Console Find dialog should remember last-searched-for string #2844

asklar opened this issue Sep 22, 2019 · 0 comments · Fixed by #2845
Assignees
@asklar
Labels
Area-Interaction Interacting with the vintage console window (as opposed to driving via API or hooks) In-PR This issue has a related PR Issue-Task It's a feature request, but it doesn't really need a major design. Product-Conhost For issues in the Console codebase
Milestone
Console Backlog

Comments

@asklar
Copy link
Member

asklar commented Sep 22, 2019

Description of the new feature/enhancement

The Find dialog in conhost does not persist its content so once the modal dialog is dismissed, bringing the dialog back up again results in an empty textbox

The feature request is to remember the last used string

Proposed technical implementation details (optional)
@asklar asklar added the Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. label Sep 22, 2019
@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Sep 22, 2019
@DHowett-MSFT DHowett-MSFT added Area-Interaction Interacting with the vintage console window (as opposed to driving via API or hooks) Issue-Task It's a feature request, but it doesn't really need a major design. Product-Conhost For issues in the Console codebase and removed Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting labels Sep 22, 2019
@DHowett-MSFT DHowett-MSFT added this to the Console Backlog milestone Sep 22, 2019
@ghost ghost removed the Needs-Tag-Fix Doesn't match tag requirements label Sep 22, 2019
@asklar asklar mentioned this issue Sep 22, 2019
Merged
5 tasks
@ghost ghost added the In-PR This issue has a related PR label Sep 22, 2019
@ghost ghost added In-PR This issue has a related PR and removed In-PR This issue has a related PR labels Sep 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@asklar asklar

Labels
Area-Interaction Interacting with the vintage console window (as opposed to driving via API or hooks) In-PR This issue has a related PR Issue-Task It's a feature request, but it doesn't really need a major design. Product-Conhost For issues in the Console codebase
Projects
None yet
Milestone
Console Backlog
Development

Successfully merging a pull request may close this issue.

Remember last-used string in the Find dialog in conhost asklar/terminal
2 participants
@DHowett-MSFT @asklar