Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Idea: Align Terminal keymappings with VS Code conventions #3140

Closed
aaronsteers opened this issue Oct 9, 2019 · 2 comments · Fixed by #4392
Closed

Idea: Align Terminal keymappings with VS Code conventions #3140

aaronsteers opened this issue Oct 9, 2019 · 2 comments · Fixed by #4392
Assignees
Labels
Area-Settings Issues related to settings and customizability, for console or terminal Issue-Task It's a feature request, but it doesn't really need a major design. Needs-Tag-Fix Doesn't match tag requirements Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.
Milestone

Comments

@aaronsteers
Copy link

aaronsteers commented Oct 9, 2019

Description of the new feature/enhancement

Would be great if we could align Terminal keybinding settings with the VS Code keybinding conventions (link below).

Currently, the shortcut keys abbreviations do not match and this makes it more difficult to get started with keybindings - requiring users to try to do tons of digging to find the right convention - for example, to know page down is 'pgdn' (Terminal) instead of 'pagedown' (VS Code).

Would be fantastic if we could memorize and use a single convention rather than inventing a new one and trying to remember which convention works in which tool.

Proposed technical implementation details (optional)

The Terminal shortcut key abbreviations are documented here:
(Couldn't find any reference docs. Eventually found examples by holding Ctr while selecting "Settings" in order to get to the defaults.json file.)

The VS Code shortcut key abbreviations are documented here:
https://code.visualstudio.com/docs/getstarted/keybindings#_accepted-keys

For example of the problem currently, "Page Up" is "pgup" in Terminal profiles.json and "pageup" in VS Code.

@aaronsteers aaronsteers added the Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. label Oct 9, 2019
@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Oct 9, 2019
@DHowett-MSFT DHowett-MSFT added Area-Settings Issues related to settings and customizability, for console or terminal Issue-Task It's a feature request, but it doesn't really need a major design. Product-Terminal The new Windows Terminal. and removed Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. labels Oct 10, 2019
@ghost ghost removed the Needs-Tag-Fix Doesn't match tag requirements label Oct 10, 2019
@DHowett-MSFT DHowett-MSFT added Help Wanted We encourage anyone to jump in on these. and removed Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting labels Oct 10, 2019
@DHowett-MSFT DHowett-MSFT added this to the Terminal v1.0 milestone Oct 10, 2019
@Pertel
Copy link

Pertel commented Oct 16, 2019

Hey, I was having the exact same problem when trying to configure keybindings using page-up and page-down; I couldn't find any documentation with all the valid keys and had to dig around in the source code.

If you'd like, I could update the documentation to list all possible keys and submit a PR.

My suggestion is to grab the keys from KeyChordSerialization.cpp
And include them in the Profiles.json Documentation file under the keybindings section.

Even if that doesn't create parity with VS Code keybindings, it would be helpful for users creating keybindings.

@ghost ghost added the In-PR This issue has a related PR label Jan 29, 2020
@ghost ghost added Needs-Tag-Fix Doesn't match tag requirements Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release. and removed Help Wanted We encourage anyone to jump in on these. In-PR This issue has a related PR labels Feb 4, 2020
@ghost
Copy link

ghost commented Feb 13, 2020

🎉This issue was addressed in #4392, which has now been successfully released as Windows Terminal Preview v0.9.433.0.:tada:

Handy links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Settings Issues related to settings and customizability, for console or terminal Issue-Task It's a feature request, but it doesn't really need a major design. Needs-Tag-Fix Doesn't match tag requirements Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants