Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Touch Zoom with two fingers don't work on Touch screen (but it works on Touch Pad) #3149

Open
DrPepperBianco opened this issue Oct 10, 2019 · 2 comments
Labels
Area-TerminalControl Issues pertaining to the terminal control (input, selection, keybindings, mouse interaction, etc.) Help Wanted We encourage anyone to jump in on these. Issue-Bug It either shouldn't be doing this or needs an investigation. Priority-2 A description (P2) Product-Terminal The new Windows Terminal.
Milestone

Comments

@DrPepperBianco
Copy link

Description of the new feature/enhancement

When I use two finger to zoom in or out (actually making text bigger or smaller), it works on my touch pad. But it actually don't work on my touch screen.

I think the experience would be much smoother if it worked the same on the touch pad and the touch screen.

What I also get is, if I scroll with finger on the touch screen it works. If I try to scroll with two fingers it flickers, as if the program doesn't realize I using two fingers and tries to read both inputs.

So the case with multiple fingers should probably be detected and handled specifically.

Proposed technical implementation details (optional)

If I use two fingers on the touch screen and move them together or away from each other the font size should decrease or increase respectively, exactly as it is now if I do that on the touch screen.

@DrPepperBianco DrPepperBianco added the Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. label Oct 10, 2019
@ghost ghost added Needs-Tag-Fix Doesn't match tag requirements Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting labels Oct 10, 2019
@carlos-zamora carlos-zamora added Area-TerminalControl Issues pertaining to the terminal control (input, selection, keybindings, mouse interaction, etc.) Help Wanted We encourage anyone to jump in on these. Product-Terminal The new Windows Terminal. and removed Needs-Tag-Fix Doesn't match tag requirements labels Oct 12, 2019
@carlos-zamora carlos-zamora added this to the Terminal v1.0 milestone Oct 12, 2019
@carlos-zamora
Copy link
Member

This should be a fairly easy thing to implement. Adding the Help-Wanted tag if anybody wants to hop on. The work should be done in the TermControl.cpp file. There's a few pointer-related functions (i.e.: pointerMoved, pointerClick, etc.) that already handle the mouse movements and a few touch events. Now just a matter of expanding on the touch events.

@DHowett-MSFT DHowett-MSFT added Issue-Task It's a feature request, but it doesn't really need a major design. and removed Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. labels Oct 23, 2019
@carlos-zamora
Copy link
Member

https://docs.microsoft.com/en-us/windows/uwp/design/input/touch-interactions

Just linking this here for when I (or somebody else) comes by 😊

@carlos-zamora carlos-zamora self-assigned this May 12, 2020
@zadjii-msft zadjii-msft added Issue-Bug It either shouldn't be doing this or needs an investigation. Priority-2 A description (P2) and removed Issue-Task It's a feature request, but it doesn't really need a major design. labels Jan 4, 2022
@zadjii-msft zadjii-msft modified the milestones: Terminal v2.0, 22H2 Jan 4, 2022
@zadjii-msft zadjii-msft modified the milestones: 22H2, Backlog Jul 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-TerminalControl Issues pertaining to the terminal control (input, selection, keybindings, mouse interaction, etc.) Help Wanted We encourage anyone to jump in on these. Issue-Bug It either shouldn't be doing this or needs an investigation. Priority-2 A description (P2) Product-Terminal The new Windows Terminal.
Projects
None yet
Development

No branches or pull requests

6 participants