Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI: active tab background should match terminal background #3310

Closed
simonferquel opened this issue Oct 24, 2019 · 2 comments
Closed

UI: active tab background should match terminal background #3310

simonferquel opened this issue Oct 24, 2019 · 2 comments
Labels
Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing.

Comments

@simonferquel
Copy link

Description of the new feature/enhancement

With some terminal background colors, spotting witch tab is active is a bit tricky:
image
In this example, with only 2 tabs open, with the same name, it is confusing.

Proposed technical implementation details (optional)

The active tab background/foreground colors should match the terminal's profile background/foreground colors:
image

@simonferquel simonferquel added the Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. label Oct 24, 2019
@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Oct 24, 2019
@zadjii-msft
Copy link
Member

We definitely agree that this is a good suggestion! It definitely needs some massaging settings-wise to make sure it's configurable the way people like, but it's a good idea. You can track the progress of this at the original issue below:

/dup #702

@ghost
Copy link

ghost commented Oct 24, 2019

Hi! We've identified this issue as a duplicate of another one that already exists on this Issue Tracker. This specific instance is being closed in favor of tracking the concern over on the referenced thread. Thanks for your report!

@ghost ghost closed this as completed Oct 24, 2019
@ghost ghost added Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing. and removed Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Oct 24, 2019
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing.
Projects
None yet
Development

No branches or pull requests

2 participants