Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: store profiles.json in a more sensible location for syncing #3588

Closed
blaineventurine opened this issue Nov 15, 2019 · 5 comments
Labels
Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing.

Comments

@blaineventurine
Copy link

Description of the new feature/enhancement

Moving profiles.json to C:\Users\xxx\AppData\Roaming\WindowsTerminal would allow it to make use of the Roaming folder, and also put it in an easier and more consistent place for people to create symlinks to sync it across several machines using OneDrive/Google Drive/NextCloud/etc.

@blaineventurine blaineventurine added the Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. label Nov 15, 2019
@ghost ghost added Needs-Tag-Fix Doesn't match tag requirements Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting labels Nov 15, 2019
@JustinGrote
Copy link

Why don't you just symlink it to that folder? That said, having a search "hint" to prioritize a path like this would be totally fine I'd say.

@blaineventurine
Copy link
Author

I do have a symlink, but making use of the Roaming folder would be an easier location to find, rather than C:\Users\xxx\AppData\Local\Packages\Microsoft.WindowsTerminal_8wekyb3d8bbwe\LocalState, and it would also allow the profiles.json file to make use of the intended purpose of the Roaming folder.

Another option would be to put it under Documents\WindowsTerminal, to keep it consistent with the location of the PowerShell profile.

@JustinGrote
Copy link

JustinGrote commented Nov 15, 2019

Yeah this one is a bit tricky, because UWP will sync the roaming across devices which can be desirable, it may not be for some people (say you have different profiles/shells installed on different systems)
https://blogs.windows.com/windowsdeveloper/2016/05/03/getting-started-with-roaming-app-data/#YbkdOulevCwxQVz0.97

As such, I still like the idea that the "default" should be localstate, but it should first look in the following locations for a config (in order of precedence) and use it if present:
%LocalAppData%\WindowsTerminal
%AppData%\WindowsTerminal
%ProgramData%\WindowsTerminal (to allow for GPO organization deployments)
appx-roaming://

@zadjii-msft
Copy link
Member

Thanks for the suggestion! We actually intentionally don't put the settings there, because as others have mentioned, it caused more problems than it solved. We're considering adding an option to re-enable that feature optionally, and you can track and discuss that feature here:

/dup #2933

@ghost
Copy link

ghost commented Nov 18, 2019

Hi! We've identified this issue as a duplicate of another one that already exists on this Issue Tracker. This specific instance is being closed in favor of tracking the concern over on the referenced thread. Thanks for your report!

@ghost ghost closed this as completed Nov 18, 2019
@ghost ghost added Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing. and removed Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Nov 18, 2019
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing.
Projects
None yet
Development

No branches or pull requests

3 participants