Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option for more subtle pane focus border #3708

Open
Studio384 opened this issue Nov 26, 2019 · 5 comments
Open

Add option for more subtle pane focus border #3708

Studio384 opened this issue Nov 26, 2019 · 5 comments
Labels
Area-User Interface Issues pertaining to the user interface of the Console or Terminal Issue-Task It's a feature request, but it doesn't really need a major design. Product-Terminal The new Windows Terminal.
Milestone

Comments

@Studio384
Copy link

Description of the new feature/enhancement

I feel like the images in #3060 are quit misleading. While the accent border isn't distracting in these images because of the bright colors set for the terminal, using normal terminal settings, the accent border is screaming for attention.

Proposed technical implementation details (optional)

I like the idea of using the accent color, but putting a border all the way around the terminal is a no-go. Perhaps a look should be taken to Windows 8's active app indication?

This should be an obvious indication, but it should not be distracting.

@Studio384 Studio384 added the Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. label Nov 26, 2019
@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Nov 26, 2019
@zadjii-msft
Copy link
Member

I'm not totally sure about what's being reported here -
Are you referring to the "active pane border" which separates two panes, and identifies which one is focused?
image
Enabling users to configure this color is being tracked in #3061

Or the "window border"
image

@zadjii-msft zadjii-msft added the Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something label Nov 26, 2019
@Studio384
Copy link
Author

I am referring to the pane borders, as per the description.

@ghost ghost added Needs-Attention The core contributors need to come back around and look at this ASAP. and removed Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something labels Nov 26, 2019
@zadjii-msft
Copy link
Member

@Studio384 Just making sure - I think the "putting a border all the way around the terminal" threw me for a loop, especially since the window border bot added in 0.7.

Would you think that being able to set the color of the pane border manually would be enough to mitigate this? If so, then #3061 is the issue for you ☺️

@zadjii-msft zadjii-msft added Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something Issue-Question For questions or discussion Product-Terminal The new Windows Terminal. and removed Needs-Attention The core contributors need to come back around and look at this ASAP. Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. labels Nov 27, 2019
@Studio384
Copy link
Author

I'd actually argue for a different indication style, perhaps something like what Windows 8.1 used to do when using Snap, A more subtle line instead of the entire border. There is nothing wrong with the color, I'm even all for it, its just the size of the indication.

@ghost ghost added Needs-Attention The core contributors need to come back around and look at this ASAP. and removed Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something labels Nov 27, 2019
@zadjii-msft zadjii-msft changed the title Make active pane indication less distracting Add option for more subtle pane focus border Nov 27, 2019
@zadjii-msft
Copy link
Member

I don't hate that idea. Might be a bit trickier to pull off, but I don't see why not.

For future self:
image

That little three dots with the line is the way it looked in 8.1.

@zadjii-msft zadjii-msft added Area-User Interface Issues pertaining to the user interface of the Console or Terminal Issue-Task It's a feature request, but it doesn't really need a major design. and removed Issue-Question For questions or discussion Needs-Attention The core contributors need to come back around and look at this ASAP. labels Nov 27, 2019
@ghost ghost removed the Needs-Tag-Fix Doesn't match tag requirements label Nov 27, 2019
@zadjii-msft zadjii-msft added this to the Terminal Backlog milestone Nov 27, 2019
@DHowett-MSFT DHowett-MSFT removed the Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting label Dec 2, 2019
@zadjii-msft zadjii-msft modified the milestones: Terminal Backlog, Backlog Jan 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-User Interface Issues pertaining to the user interface of the Console or Terminal Issue-Task It's a feature request, but it doesn't really need a major design. Product-Terminal The new Windows Terminal.
Projects
None yet
Development

No branches or pull requests

3 participants