Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

when starting git gui in Powershell 5.1, next line shows ANSI codes #3767

Closed
peetrike opened this issue Nov 28, 2019 · 1 comment
Closed
Labels
Needs-Tag-Fix Doesn't match tag requirements Resolution-External For issues that are outside this codebase

Comments

@peetrike
Copy link

peetrike commented Nov 28, 2019

Environment

Windows build number: 10.0.18363.0
Windows Terminal version (if applicable): 0.7.3291 (and 0.6.2951.0)

Any other software?
Git for windows (v2.24.0.windows.2)
Windows Powershell v5.1

Steps to reproduce

  1. On Windows Powershell prompt enter git gui
  2. On next line start entering next command

Expected behavior

the entered text shows as it is supposed, with correct coloring from PSReadline.

Actual behavior

ANSI escape codes are showed until Enter is pressed. The actual input is correctly executed.

image

When PSReadline module is removed from session, the problem ceases to exist.

@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Nov 28, 2019
@DHowett-MSFT
Copy link
Contributor

This is a bad interaction between PSReadline and git -- one or the other is failing to restore the console mode to one that supports VT. Does it work with the new PSReadline verison in PowerShell 6/7?

(closing this as it's a shell/application issue)

@DHowett-MSFT DHowett-MSFT added the Resolution-External For issues that are outside this codebase label Nov 30, 2019
@DHowett-MSFT DHowett-MSFT removed the Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting label Dec 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs-Tag-Fix Doesn't match tag requirements Resolution-External For issues that are outside this codebase
Projects
None yet
Development

No branches or pull requests

2 participants