Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: Dynamic settings attribute(s) toggle #4198

Open
mkitzan opened this issue Jan 13, 2020 · 2 comments
Open

Feature request: Dynamic settings attribute(s) toggle #4198

mkitzan opened this issue Jan 13, 2020 · 2 comments
Labels
Area-Extensibility A feature that would ideally be fulfilled by us having an extension model. Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. Product-Terminal The new Windows Terminal.
Milestone

Comments

@mkitzan
Copy link
Contributor

mkitzan commented Jan 13, 2020

Description of the new feature/enhancement

Recently, a few issues have popped up expressing an interest in a feature which could support the dynamic switching of the colors and styling settings attributes of an open Profile. The following settings attributes could be made to support dynamic switching:

  • colorScheme (if nothing else this is a must support)
  • foreground
  • background
  • backgroundImage
  • fontSize
  • fontFace
  • requestedTheme

Issues which are related to this generic feature request:

Proposed technical implementation details (optional)

It would make sense to implement the switching trigger as a shortcut key binding which changes the present tab's colorScheme to a preset scheme. When the colorScheme has been switched and the shortcut key is pressed again it could return to the default scheme for the tab's profile.

Potentially this shortcut key could be bound to switch not only the colorScheme but also other settings attributes as well (like fontSize). The return to default behavior could be applied to all the switched attributes.

@mkitzan mkitzan added the Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. label Jan 13, 2020
@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Jan 13, 2020
@DHowett-MSFT DHowett-MSFT added Area-Extensibility A feature that would ideally be fulfilled by us having an extension model. Product-Terminal The new Windows Terminal. and removed Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting labels Jan 13, 2020
@ghost ghost removed the Needs-Tag-Fix Doesn't match tag requirements label Jan 13, 2020
@DHowett-MSFT DHowett-MSFT added this to the Terminal Backlog milestone Jan 13, 2020
@DHowett-MSFT
Copy link
Contributor

With a scope like this, it might be best to handle this as an extension. 😄 I've tagged it as such.

@zadjii-msft
Copy link
Member

You know, the majority of this ask was probably accomplished by the setColorScheme action. I think we've got other requests laying around for setFontSize (instead of just adjustFontSize). Combine these sorts of things with a multipleActions action, and we might get the effect we're looking for here.

@zadjii-msft zadjii-msft modified the milestones: Terminal Backlog, Backlog Jan 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Extensibility A feature that would ideally be fulfilled by us having an extension model. Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. Product-Terminal The new Windows Terminal.
Projects
None yet
Development

No branches or pull requests

3 participants