Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Teminal doesn't preserve colored blocks of characters. #4300

Closed
elbertlev opened this issue Jan 19, 2020 · 4 comments
Closed

Teminal doesn't preserve colored blocks of characters. #4300

elbertlev opened this issue Jan 19, 2020 · 4 comments
Labels
Area-Output Related to output processing (inserting text into buffer, retrieving buffer text, etc.) Issue-Task It's a feature request, but it doesn't really need a major design. Priority-3 A description (P3) Product-Conhost For issues in the Console codebase Product-Terminal The new Windows Terminal. Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing.

Comments

@elbertlev
Copy link

Environment

Windows build number: 10.0.18362.592
Windows Terminal version (if applicable): 0.8.10091.0

Steps to reproduce

  1. Launch the Windows Terminal (it opens the Powershell tab)
  2. Run any of the color16.bat (or any other .bat file) file from https://gist.github.com/k-takata/2d4f562bacf8bae6691973a540970117#file-color256_block-sh
  3. The colored block is drown
  4. Resize the terminal window and observe the colored block disappears.

Expected behavior

The colored block should be preserved
image

Actual behavior

The colored block disappears.
Note. The same behaviour in all kinds of shells it terminal (cmd, bash) and in standalone cmd.exe

@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Jan 19, 2020
@zadjii-msft zadjii-msft added Area-Output Related to output processing (inserting text into buffer, retrieving buffer text, etc.) Issue-Task It's a feature request, but it doesn't really need a major design. Priority-3 A description (P3) Product-Conhost For issues in the Console codebase Product-Terminal The new Windows Terminal. labels Jan 19, 2020
@ghost ghost removed the Needs-Tag-Fix Doesn't match tag requirements label Jan 19, 2020
@zadjii-msft zadjii-msft added this to the Console Backlog milestone Jan 19, 2020
@zadjii-msft
Copy link
Member

Yea, this is true. Since the console buffer can't know the difference between "no character" and "space", when the console buffer resizes, it doesn't know to copy that color information over. This is technically the same bug as #32 - I'll leave it to the rest of the team to decide if this should be left open or closed as a dupe.

@elbertlev
Copy link
Author

Thank you for prompt response. I believe I found the reason for such behavior.
Let's start with cmd.exe. It behaves exactly the same way as terminal if "Wrap text output on resize" is enabled. If disabled it works as it should.
The terminal settings do not include such option (at least I don't know how to disable wrapping).

I think it is possible to make cmd and terminal work correctly with wrapping, but don't know is it worth the efforts. After all you are mimicking the full screen mode. Maybe documenting is enough. Also it would be nice to check the behavior of a real Linux terminal.

@DHowett-MSFT DHowett-MSFT removed the Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting label Jan 23, 2020
@DHowett-MSFT
Copy link
Contributor

I'm gonna call this one officially a /dup of #32. Thanks!

@ghost
Copy link

ghost commented Jan 23, 2020

Hi! We've identified this issue as a duplicate of another one that already exists on this Issue Tracker. This specific instance is being closed in favor of tracking the concern over on the referenced thread. Thanks for your report!

@ghost ghost closed this as completed Jan 23, 2020
@ghost ghost added the Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing. label Jan 23, 2020
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Output Related to output processing (inserting text into buffer, retrieving buffer text, etc.) Issue-Task It's a feature request, but it doesn't really need a major design. Priority-3 A description (P3) Product-Conhost For issues in the Console codebase Product-Terminal The new Windows Terminal. Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing.
Projects
None yet
Development

No branches or pull requests

3 participants