Light theme is not supported well?

[learning]

Environment

Windows build number: 10.0.18363.657
Windows Terminal version (if applicable): 0.9.433.0

Any other software?
1. Debian Linux (WSL)
2. fish shell

Steps to reproduce

Use ColorTool convert this Github style iTerm2 color theme, and add it to Windows Terminal

My color scheme in Windows Terminal:

{
    "name": "github",
    "black":"#3e3e3e",
    "blue":"#003e8a",
    "green":"#07962a",
    "cyan":"#89d1ec",
    "red":"#970b16",
    "purple":"#e94691",
    "yellow":"#f8eec7",
    "white":"#ffffff",
    "brightBlack":"#666666",
    "brightBlue":"#2e6cba",
    "brightGreen":"#87d5a2",
    "brightCyan":"#1cfafe",
    "brightRed":"#de0000",
    "brightPurple":"#ffa29f",
    "brightYellow":"#f1d007",
    "brightWhite":"#ffffff",
    "foreground":"#3e3e3e",
    "background":"#ffffff",
    "selectionBackground": "#ffa29f"
}

Expected behavior

Just like iTerm2 in macOS

Actual behavior

Some text is in white, the same color with background

[learning]

Not only the Node.js+webpack, it goes crazy when I use fish shell.

[hanubeki]

Could be #293 and/or #2661

[zadjii-msft]

I'm just reposting the theme here so you can preview the colors here

Color sheme

"name": "github",
"black": #3e3e3e,
"blue": #003e8a,
"green": #07962a,
"cyan": #89d1ec,
"red": #970b16,
"purple": #e94691,
"yellow": #f8eec7,
"white": #ffffff,
"brightBlack": #666666,
"brightBlue": #2e6cba,
"brightGreen": #87d5a2,
"brightCyan": #1cfafe,
"brightRed": #de0000,
"brightPurple": #ffa29f,
"brightYellow": #f1d007,
"brightWhite": #ffffff,
"foreground": #3e3e3e,
"background": #ffffff,
"selectionBackground": #ffa29`

I'd bet that this was #293, but I'm not seeing this orange color

anywhere in that scheme. Maybe you could edit the foreground, white, or brightWhite colors, to see if text is getting printed in any of those colors at all?

[DHowett-MSFT]

But given that you do have working black text, I believe this is because the application is explicitly requesting "white". It's also correct that you have not specified that orange color in this color scheme. Perhaps that's what you should put in place of White?

[DHowett-MSFT]

Oh, @zadjii-msft, this is actually because we don't have "bold foreground" (color 19)... eeeeee

[ghost]

This issue has been automatically marked as stale because it has been marked as requiring author feedback but has not had any activity for 4 days. It will be closed if no further activity occurs within 3 days of this comment.

[j4james]

Oh, @zadjii-msft, this is actually because we don't have "bold foreground" (color 19)... eeeeee

Note that there is quite a lot of variation in the way different terminal emulators deal with the concept of a bold foreground color. Xterm has some OSC sequences for controlling attribute colors (see OSC 5/6, etc) that are partially supported by some other terminals, but I think iTerm2 actually uses something completely different.

There are also standard DEC sequences for controlling attribute colors (e.g. DECATC), although they serve a somewhat different purpose. However, if we are going to support something like this, I think it would be nice if we could at least consider how it might fit in with the standard behavior.

[ghost]

This issue has been automatically marked as stale because it has been marked as requiring author feedback but has not had any activity for 4 days. It will be closed if no further activity occurs within 3 days of this comment.

[learning]

I'm just reposting the theme here so you can preview the colors here
Color sheme

I'd bet that this was #293, but I'm not seeing this orange color

anywhere in that scheme. Maybe you could edit the foreground, white, or brightWhite colors, to see if text is getting printed in any of those colors at all?

Yes, I have tried to adjust foreground color for the fish and webpack, but it turns unreadable elsewhere, like ls, vim or git, the daily tools.

[DHowett-MSFT]

Thanks everyone for your input here. Now that we know the root cause, I'm going to refer to the new issue filed to track it. /dup #5682.

[ghost]

Hi! We've identified this issue as a duplicate of another one that already exists on this Issue Tracker. This specific instance is being closed in favor of tracking the concern over on the referenced thread. Thanks for your report!