CTRL+f Search in Buffer

[fischerdouglas]

Description of the new feature/enhancement

A way to search in buffer of local session for some string.
It could/should be triggered by a key combination (like CTRL+f, as in all other apps).

Proposed technical implementation details (optional)

Once again: "Nothing is created, everything is copied."
So, in Iterm2 we have the feature:

Regular Expression Search
When you open the find field (cmd-f) there is a down-arrow on the left of the field by the magnifying glass. Clicking it opens a menu of options in which you can enable regular expression search. The ICU syntax is used.

Source -> https://www.iterm2.com/documentation-one-page.html

On the first moment a simple string match is OK.
But regular expression is "the way and the truth and the life". So this would be a great idea.

Visual Studio supports regular expression based searchs!
Maybe this link could be inspiring:
https://docs.microsoft.com/pt-br/visualstudio/ide/using-regular-expressions-in-visual-studio?view=vs-2019

An extra ideia is:

• Search only on local buffer.
• Search on the buffer of all the open tabs.

[fischerdouglas]

Default Powershell App has a dummy CTRL+F

The CTRL+F doesn`t actualy works as expect.
(It sends a ^F to the input)

You need to Rigth-Click on Title bar -> Edit -> Find
But at least i can search with it.

(Sorry, I'm using pt_BR as my default Language.)

[zadjii-msft]

Thanks for the suggestion! This is something we already support today - it's bound to Ctrl+shift+f by default. As far as improvements go, we've got #3920 tracking a number of improvements, including:

• Add "Find" button in dropdown menu to trigger search. Now the search dialog is launched by key bindings, we may need to consider binding the dialog to a button in dropdown menu for mouse only operations.
• Search from all tabs. In phase one search are limited within one Terminal window. However, the community also requests search from all tabs. This may require a big change to the search algorithm.
• Regular expression match. This is a useful search pattern and is implemented in some editors.
• Search history. Sometimes users would do the same search for several times, thus, storing the search history is useful.
• High-light while you type. Emphasizing all the matches in the buffer with an outline or selection with another color. This provides a clearer view of the searched text.
• Add size handle. Some text editors let the user resize the search box, and there is a size handle on the left side of the search box. This helps user when they search for long text.
• Feature Request: Fuzzy Search #5314 Fuzzy Search

/dup #3920

[ghost]

Hi! We've identified this issue as a duplicate of another one that already exists on this Issue Tracker. This specific instance is being closed in favor of tracking the concern over on the referenced thread. Thanks for your report!

[fischerdouglas]

Hey man...
I'm feeling stupid... I'm doing questions and suggestions that are already replied/solved.

I'm used to that exhausting docs from MS products... (like exchange, or sql-server)

I don't know what docs I need to read to stop that stupid questions about Windows Terminal.
(Please don't tell-me that the recommended reading is all the issues related to the project)

[DHowett-MSFT]

Sorry about that. As of today, all our documentation is in the user-docs folder on this repository and in the settings files. The default settings file has an explicit callout for search 😄

We're working on making sure our documentation is available, discoverable and accessible.

[yanke1311]

when I use ctrl+shift+f, I can no longer find any change, and in setting I really have setted key-binding of "find", I don't know what happend?

[DHowett]

Can you share your settings file?

[DHowett]

I'm sorry, you put it into your json file with the three ``` in it? Don't do that.

Also, it looks like you have a very old version of terminal settings. You might be a lot happier if you migrate to the new format (back up the things you care about, delete the file, and let Terminal make a new one.)

[yanke1311]

so strange , even I migrate to the new format, "find" is still not work

[DHowett]

Okay can you share your new settings file?

[yanke1311]

the code block is automatically by markdown of github, and in my json, there is no ```

[yanke1311]

I have known it , ctrl+shift+f will conflict to input method of system in chinese. thank you @DHowett !!

[DHowett]

Oh! Thank you!