Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multi-click selection granularity #6511

Open
andrzejnovak opened this issue Jun 15, 2020 · 3 comments
Open

Multi-click selection granularity #6511

andrzejnovak opened this issue Jun 15, 2020 · 3 comments
Labels
Area-Extensibility A feature that would ideally be fulfilled by us having an extension model. Area-TerminalControl Issues pertaining to the terminal control (input, selection, keybindings, mouse interaction, etc.) Area-User Interface Issues pertaining to the user interface of the Console or Terminal Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. Product-Terminal The new Windows Terminal.
Milestone

Comments

@andrzejnovak
Copy link

Description of the new feature/enhancement

The current multi-click selection expansion only has two steps.

  • double-click: selects a "word" between 2 delimiters (don't have to be the same, e.g. , and so when clicking on a filename, you don't get the extension)

  • triple-click: selects the entire line

I find myself rarely needing the entire line, but often need a path or a filename usually separated by spaces.

I would propose the following as better UX without going too granular.

  • double-click: selects a "word" between 2 same delimiters
  • triple-click: selects an entire string separated by spaces
  • 4-click: entire line
@andrzejnovak andrzejnovak added the Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. label Jun 15, 2020
@ghost ghost added Needs-Tag-Fix Doesn't match tag requirements Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting labels Jun 15, 2020
@DHowett
Copy link
Member

DHowett commented Jun 26, 2020

You know, I don't hate this as much as I thought I would. Perhaps we do need some different mechanics.

I'm inclined to call this extensible and link it up to #4000.

@DHowett DHowett added Area-Extensibility A feature that would ideally be fulfilled by us having an extension model. Area-TerminalControl Issues pertaining to the terminal control (input, selection, keybindings, mouse interaction, etc.) Area-User Interface Issues pertaining to the user interface of the Console or Terminal Product-Terminal The new Windows Terminal. and removed Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting labels Jun 26, 2020
@ghost ghost removed the Needs-Tag-Fix Doesn't match tag requirements label Jun 26, 2020
@DHowett DHowett added this to the Terminal Backlog milestone Jun 26, 2020
@andrzejnovak
Copy link
Author

Yup, would be fine as a config/extension.

@benmwatson
Copy link
Member

I would love to have the triple-click behave as you say. I was about to file an issue for this as well. One interesting quirk with the full-line selection and copying. If I copy and paste a full line, all spaces after the last text are being discarded. But spaces before the text are being preserved. It's as if they're calling TrimRight(), but not TrimLeft().

I could almost be happy if they could just trim those left spaces, but I'd love to see more deliberate behavior as you describe above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Extensibility A feature that would ideally be fulfilled by us having an extension model. Area-TerminalControl Issues pertaining to the terminal control (input, selection, keybindings, mouse interaction, etc.) Area-User Interface Issues pertaining to the user interface of the Console or Terminal Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. Product-Terminal The new Windows Terminal.
Projects
None yet
Development

No branches or pull requests

4 participants