Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a fluent animation for pane zooming #7216

Open
zadjii-msft opened this issue Aug 7, 2020 · 1 comment
Open

Add a fluent animation for pane zooming #7216

zadjii-msft opened this issue Aug 7, 2020 · 1 comment
Labels
Area-User Interface Issues pertaining to the user interface of the Console or Terminal Help Wanted We encourage anyone to jump in on these. Issue-Task It's a feature request, but it doesn't really need a major design. Product-Terminal The new Windows Terminal.
Milestone

Comments

@zadjii-msft
Copy link
Member

Related to #1001, and a follow-up to #6989

It'd also be nice if we had an animation. Idk if you want that to be a part of #1001 though. If you do punt on the animation, could you just add a note on that issue (or open a new one).

@zadjii-msft zadjii-msft added Help Wanted We encourage anyone to jump in on these. Area-User Interface Issues pertaining to the user interface of the Console or Terminal Product-Terminal The new Windows Terminal. Issue-Task It's a feature request, but it doesn't really need a major design. labels Aug 7, 2020
@zadjii-msft zadjii-msft added this to the Terminal Backlog milestone Aug 7, 2020
@ghost ghost added the Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting label Aug 7, 2020
@DHowett DHowett removed the Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting label Aug 7, 2020
@zadjii-msft
Copy link
Member Author

Alright so insomnia-thought:

  • When we zoom the pane, don't remote the other panes from the tree. Instead, take the zoomed pane's control out.
  • add the zoomed pane's content to the root grid of the page.
  • resize the TermControl to be the full size
  • force the panes control to start as a size of W,H=(originalWidth, originalHeight).
  • force the panes's control (the one that's now a child of the root grid) to be at the same x,y it was originally (set a Translation maybe?)
  • Animate the pane's control's x,y -> (0,0)
  • Animate the pane's w,h -> (rootWidth, rootHeight)

so the pane will just be drawn on top of the other panes in the tree, and it'll look like it started where it originally was, and at it's original size, but it's actually just on top of all of them.


We'd want to have another new animation for "move focus while zoomed", once #7215 is done too, but one step at a time

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-User Interface Issues pertaining to the user interface of the Console or Terminal Help Wanted We encourage anyone to jump in on these. Issue-Task It's a feature request, but it doesn't really need a major design. Product-Terminal The new Windows Terminal.
Projects
None yet
Development

No branches or pull requests

2 participants