Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[discussion] Disable/pause automatic scroll down #7406

Closed
vadimkantorov opened this issue Aug 26, 2020 · 3 comments
Closed

[discussion] Disable/pause automatic scroll down #7406

vadimkantorov opened this issue Aug 26, 2020 · 3 comments
Labels
Issue-Question For questions or discussion Needs-Tag-Fix Doesn't match tag requirements Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Resolution-Answered Related to questions that have been answered

Comments

@vadimkantorov
Copy link

vadimkantorov commented Aug 26, 2020

A usecase: a long-running build process that prints occasionally noteworthy things to terminal. I scroll up and want to read them or copy them. However when new output from build appears on screen, the terminal automatically scrolls down (even if I'm still dragging scrollbar by mouse).

In this usecase we would like to disable automatic scroll down and let the user inspect the previous output. Some options to support this usecase: disable this altogether (the user should scroll down themselves to resume auto-scroll-down); provide some keyboard/UI shortcut to enable this.

I think Gnome Terminal doesn't do this, but I don't remember for sure.

@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Aug 26, 2020
@DHowett
Copy link
Member

DHowett commented Aug 26, 2020

Thanks! So, there’s a couple issues at play here.

We recently (1.2) implemented scroll locking when you are scrolled up or have an active selection. That part is automatic and unconfigurable. Scrolling will snap back when you press Print Screen a key that sends input (😉).

We had (fixed in #7247) a bug where we would let the buffer roll underneath the locked scroll region. The fix is about to come out with 1.2.2381.0.

We also have a critical lack of support for infinite scrollback, so you have between 9001 and 32k lines, depending on how you configured Terminal, to print out before the locked scroll region will age out. I can’t pull that issue up in quicksearch on my phone.

With those two things noted, do we need further discussion? 😄

@DHowett DHowett added the Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something label Aug 26, 2020
@vadimkantorov
Copy link
Author

vadimkantorov commented Aug 26, 2020

No, I think we're good :) It would be fantastic to have this scenario to added on your functional testing usecase list or something like that :)

One minor detail is that it can be hard to re-enable back auto-scrolling when the scrollbar became small enough or new text appears fast - so some slack/docking there would be good

@ghost ghost added Needs-Attention The core contributors need to come back around and look at this ASAP. and removed Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something labels Aug 26, 2020
@zadjii-msft
Copy link
Member

Oh don't worry, we've already got the test covered.

Thanks for following up!

@zadjii-msft zadjii-msft added Issue-Question For questions or discussion Resolution-Answered Related to questions that have been answered and removed Needs-Attention The core contributors need to come back around and look at this ASAP. labels Aug 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Issue-Question For questions or discussion Needs-Tag-Fix Doesn't match tag requirements Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Resolution-Answered Related to questions that have been answered
Projects
None yet
Development

No branches or pull requests

3 participants