Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Autocompletion in git bash for windows flashes/blinks #7688

Closed
mlewand opened this issue Sep 21, 2020 · 5 comments
Closed

Autocompletion in git bash for windows flashes/blinks #7688

mlewand opened this issue Sep 21, 2020 · 5 comments
Labels
Issue-Question For questions or discussion Needs-Tag-Fix Doesn't match tag requirements Resolution-Answered Related to questions that have been answered

Comments

@mlewand
Copy link

mlewand commented Sep 21, 2020

Environment

Windows build number: Version 10.0.19041.508
Windows Terminal version (if applicable): 1.2.2381.0

Any other software?
Git(git for Windows): 2.28.0

Steps to reproduce

  1. Open a new git bash tab.
  2. Navigate to your windows directory.
  3. Type "cd syst".
  4. Press tab twice.

Expected behavior

Screen doesn't flash, your command is unfolded to "cd system".

Actual behavior

Screen flashes gray for a moment.

If you inspect the gif frame-by-frame it actually inverts colors, rather than make it all single color:

Interestingly it doesn't happen consistently. If I backspace it twice (so that it is "cd syst" again) and press tab, there might be no flash this time.

It's not reproducible in git bash console app itself.

It's a regression that happened over last quarter or so, but I'm surprised I didn't find any existing issue on that.

Here's how the prfilefor bash is defined:

   "profiles": [
        {
            "acrylicOpacity": 1,
            "closeOnExit": true,
            "colorScheme": "Campbell",
            "commandline": "<basePath>\\usr\\bin\\bash.exe\" -i -l",
            "cursorColor": "#FFFFFF",
            "cursorShape": "bar",
            "fontFace": "Consolas",
            "fontSize": 8,
            "guid": "{0504d9fc-deca-44e1-83c4-213dca5023e7}",
            "historySize": 9001,
            "icon": "<basePath>\\mingw64\\share\\git\\git-for-windows.ico",
            "name": "Bash",
            "padding": "0, 0, 0, 0",
            "snapOnInput": true,
            "startingDirectory": "%USERPROFILE%",
            "useAcrylic": true
        },
@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Sep 21, 2020
@mlewand mlewand changed the title Autocompletion in git bash for windows Autocompletion in git bash for windows flashes/blinks Sep 21, 2020
@skyline75489
Copy link
Collaborator

skyline75489 commented Sep 21, 2020

It may sounds crazy but I think this is actual expected. It's a so-called "Visual Bell". Think of it as a replacement for audible bell.

@DHowett
Copy link
Member

DHowett commented Sep 21, 2020

Yes, this is a "visual bell". Here is a comprehensive list of ways to turn of visual bells.

@DHowett DHowett closed this as completed Sep 21, 2020
@DHowett DHowett added Issue-Question For questions or discussion Resolution-Answered Related to questions that have been answered and removed Needs-Tag-Fix Doesn't match tag requirements Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting labels Sep 21, 2020
@ghost ghost added the Needs-Tag-Fix Doesn't match tag requirements label Sep 21, 2020
@mlewand
Copy link
Author

mlewand commented Sep 22, 2020

Oh, thanks! Didn't know about that 👍

@martins-1992
Copy link

martins-1992 commented Apr 26, 2021

Considering the fact, that this effect does not appear in git bash for Windows itself,
wouldn't it be helpful to add an FAQ to https://docs.microsoft.com/de-de/windows/terminal/tips-and-tricks or even the App itself?

@DHowett
Copy link
Member

DHowett commented Apr 26, 2021

Considering the fact, that this effect does not appear in git bash for Windows itself,

It will on a version of Windows where the console host has the aforementioned change. Promise.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Issue-Question For questions or discussion Needs-Tag-Fix Doesn't match tag requirements Resolution-Answered Related to questions that have been answered
Projects
None yet
Development

No branches or pull requests

4 participants