Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Screen Reader-Command Palette]-Narrator focus is not in sync while navigating using arrow keys in suggestion list after searching for any command. #7911

Open
DasaradhaKamjula opened this issue Oct 13, 2020 · 2 comments
Labels
A11yCO Accessibility tracking A11ySev3 Accessibility tracking A11yWCAG Accessibility tracking Area-Accessibility Issues related to accessibility Area-CmdPal Command Palette issues and features Area-User Interface Issues pertaining to the user interface of the Console or Terminal HCL-E+D Accessibility tracking HCL-WindowsTerminal Accessibility tracking Impact-Compliance It gotta be this way. Issue-Bug It either shouldn't be doing this or needs an investigation. Priority-3 A description (P3) Product-Terminal The new Windows Terminal.
Milestone

Comments

@DasaradhaKamjula
Copy link
Collaborator

DasaradhaKamjula commented Oct 13, 2020

User Experience:
Users who rely on screen reader will not be able get the control info if narrator focus is not in sync with arrow keys

Test Environment:
App: Windows Terminal Preview
Feature: Command Palette
Screen Reader: Narrator
OS: Win 10 2004 Build (19041.508)

Repro Steps:
1.Open Windows terminal Preview app
2.Open Command Palette using shortcut (Ctrl+shift+p)
3.Search for any command in the search field
4.Navigate using arrow key in the suggestion list.
5.Verify whether narrator focus moves onto suggestion list when user press down arrow key to move onto suggestions

Actual:
Narrator focus is not in sync while navigating using arrow keys in suggestion list after searching for any command.

Expected:
Narrator focus should be in sync while navigating using arrow keys in suggestion list after searching for any command so that screen reader can read the focused control info.

MAS Reference:
https://microsoft.sharepoint.com/:w:/r/teams/msenable/_layouts/15/WopiFrame.aspx?sourcedoc={b24201d1-2276-4471-8183-e1e5353031ad}

@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Oct 13, 2020
@zadjii-msft zadjii-msft added Area-Accessibility Issues related to accessibility Area-User Interface Issues pertaining to the user interface of the Console or Terminal Product-Terminal The new Windows Terminal. Impact-Compliance It gotta be this way. labels Oct 13, 2020
@zadjii-msft zadjii-msft added this to the Terminal v2.0 milestone Oct 15, 2020
@DHowett DHowett added Issue-Bug It either shouldn't be doing this or needs an investigation. and removed Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting labels Oct 16, 2020
@ghost ghost removed the Needs-Tag-Fix Doesn't match tag requirements label Oct 16, 2020
@cinnamon-msft cinnamon-msft added the HCL-E+D Accessibility tracking label Oct 20, 2020
@zadjii-msft zadjii-msft added the Area-CmdPal Command Palette issues and features label Dec 1, 2020
@Chandresh1007 Chandresh1007 added HCL-WindowsConsole Accessibility tracking HCL-WindowsTerminal Accessibility tracking A11yWCAG Accessibility tracking labels Dec 7, 2020
@carlos-zamora
Copy link
Member

I'm thinking that this might be able to be resolved by specifically handling the "up/down" arrow key events. We should try moving the focus programmatically to the highlighted item. Then, when you're typing any other key/character, we should move focus back to the text box. I'll play around with this today.

@awalia13 awalia13 added the A11yCO Accessibility tracking label Mar 10, 2021
@awalia13 awalia13 added the A11ySev3 Accessibility tracking label Jun 1, 2021
@zadjii-msft zadjii-msft added the Priority-1 A description (P1) label Jul 15, 2021
@Priyanka-Chauhan123 Priyanka-Chauhan123 removed the HCL-WindowsConsole Accessibility tracking label Jul 21, 2021
@Neurrone
Copy link

I just ran into this as well when using it with NVDA. The unintuitive thing to do is to press tab to move focus from the text field to the list of suggestions to have it read with u/down arrow.

@zadjii-msft zadjii-msft modified the milestones: Terminal v2.0, 22H2 Jan 3, 2022
@zadjii-msft zadjii-msft added Priority-3 A description (P3) and removed Priority-1 A description (P1) labels Aug 23, 2022
@zadjii-msft zadjii-msft modified the milestones: 22H2, Backlog Dec 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A11yCO Accessibility tracking A11ySev3 Accessibility tracking A11yWCAG Accessibility tracking Area-Accessibility Issues related to accessibility Area-CmdPal Command Palette issues and features Area-User Interface Issues pertaining to the user interface of the Console or Terminal HCL-E+D Accessibility tracking HCL-WindowsTerminal Accessibility tracking Impact-Compliance It gotta be this way. Issue-Bug It either shouldn't be doing this or needs an investigation. Priority-3 A description (P3) Product-Terminal The new Windows Terminal.
Projects
None yet
Development

No branches or pull requests

9 participants