Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tab switching doesn't work correctly when using custom key bindings #8290

Closed
sivadeilra opened this issue Nov 16, 2020 · 3 comments
Closed
Labels
Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing.

Comments

@sivadeilra
Copy link

Environment

Windows build number: 10.0.20257.1
Windows Terminal version (if applicable): 1.5.3142.0

Any other software?

Steps to reproduce

Modify settings.json and add new key bindings for nextTab and prevTab, like so:

"actions": {
        { "command": { "action": "nextTab" }, "keys": "ctrl+pgdn" },
        { "command": { "action": "prevTab" }, "keys": "ctrl+pgup" }
}

Save these settings. Open 4 or 5 tabs. Now try to use Control+PgUp / Control+PgDown to cycle through the tabs. It doesn't work -- it gets "stuck" on just one or two of the tabs.

Expected behavior

I expect that binding to nextTab / prevTab works. It used to work in older versions of Windows Terminal.

Actual behavior

The tab switcher gets "stuck" on one or two tabs, and it won't switch to any others.

@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Nov 16, 2020
@Don-Vito
Copy link
Contributor

Don-Vito commented Nov 16, 2020

@sivadeilra - seems like a duplicate of #8247. A fix for it was already merged to master.

@zadjii-msft
Copy link
Member

Yep, this is a dupe. Thanks for the triage help @Don-Vito!

/dup #8247

@ghost
Copy link

ghost commented Nov 17, 2020

Hi! We've identified this issue as a duplicate of another one that already exists on this Issue Tracker. This specific instance is being closed in favor of tracking the concern over on the referenced thread. Thanks for your report!

@ghost ghost closed this as completed Nov 17, 2020
@ghost ghost added Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing. and removed Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Nov 17, 2020
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing.
Projects
None yet
Development

No branches or pull requests

3 participants