Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ctrl + Shift + Mouse Wheel doesn't change transparancy with useAcrylic set to true #830

Closed
henryleberre opened this issue May 15, 2019 · 16 comments
Labels
Area-Settings Issues related to settings and customizability, for console or terminal Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Attention The core contributors need to come back around and look at this ASAP. Needs-Repro We can't figure out how to make this happen. Please help find a simplified repro. Needs-Tag-Fix Doesn't match tag requirements Product-Terminal The new Windows Terminal.

Comments

@henryleberre
Copy link

henryleberre commented May 15, 2019

I am new to the new windows terminal but I am experiencing an issue where the transparency is not applied with "useAcrylic" set to true in my "profiles.json" file as shown in another issue post. I built it with visual studio 2017 and "Microsoft Windows [version 10.0.18898.1000]". I cloned the repository today.

Is there an issue or is it because of my lack of knowledge with this awesome new fancy terminal?
Thanks!

It is in the txt format because github doesn't accept .json files.
profiles.txt

@mKay00
Copy link
Contributor

mKay00 commented May 16, 2019

What if you set the transparency manually in the profiles.json? Does the transparency work? Is the window in focus? Are you sure you have saved the changes of your profiles.json? Try deinstalling and rebuilding it and then change again to true.

@zadjii-msft
Copy link
Member

There are other things that affect acrylic that are out of our control. For example, acrylic doesn't render through remote desktop sessions, and IIRC, it doesn't render on battery saver either. It is also well documented that it only renders on windows that are actively focused.

If your profile has useAcrylic set, you can change the opacity of the acrylic with Ctrl+Shift+mouse wheel

@zadjii-msft zadjii-msft added Area-Settings Issues related to settings and customizability, for console or terminal Needs-Repro We can't figure out how to make this happen. Please help find a simplified repro. labels May 16, 2019
@henryleberre
Copy link
Author

henryleberre commented May 16, 2019

Thank you for your suggestions but I have rebuilt it several times with fresh clones of the repository and the problem persisted. I have verified that low battery mode was off and I am not using it through a remote session and the window is focused. Changing the AcrylicOpacity setting doesn't do anything. I will provide the profiles.json file. Opacity doesn't work but zooming with shift mouse wheel works.

@henryleberre henryleberre changed the title ctr + shift + scroll doesn't change transparancy with useAcrylic set to true Ctrl + Shift + Mouse Wheel doesn't change transparancy with useAcrylic set to true May 16, 2019
@mKay00
Copy link
Contributor

mKay00 commented May 16, 2019

I tried your profiles settings and they work for me. Maybe an issue with the Windows version? I am on 18362.

@ghost ghost added the Needs-Tag-Fix Doesn't match tag requirements label May 17, 2019
@DHowett-MSFT DHowett-MSFT added Issue-Bug It either shouldn't be doing this or needs an investigation. Product-Terminal The new Windows Terminal. labels May 17, 2019
@ghost ghost removed the Needs-Tag-Fix Doesn't match tag requirements label May 17, 2019
@henryleberre
Copy link
Author

Would me uploading my compiled version help?

@garyparrot
Copy link

I can't change the transparency by Ctrl+Shift+Mouse wheel too.

I have checked the source code of CascadiaSettings.cpp and AppKeyBindings.cpp.
And seems there doesn't exist any key binding about Ctrl+Shift+Mouse for change transparency.

But at the conference, they actually perform this key binding.

I guess they didn't commit this feature yet.
Just a guess, I am not sure that is the reason.

@henryleberre
Copy link
Author

The key binding must exist since mKay00 said it worked for him.. I will try to find it when I have time. What is your windows version garyparrot? It seems to be linked somehow but I am not sure.

@garyparrot
Copy link

garyparrot commented May 18, 2019

I am running 18362.30

I just find out I can actually change the transparency by mouse wheel.
But I have to keep scrolling the wheel in the same direction very hard in order to see the change.

@henryleberre
Copy link
Author

I have tried setting the scroll sensitivity to the maximum but it still doesn't work... It is very interesting that it works for you! We are getting close!

@zadjii-msft
Copy link
Member

The "keybinding" isn't actually set as a KeyBinding, since KeyBindings are for key combos, while this is a mouse interaction.

Mouse wheel events are handled here:
https://github.com/microsoft/terminal/blob/master/src/cascadia/TerminalControl/TermControl.cpp#L696-L717

I'd set a breakpoint there to make sure it's getting hit for you.

@garyparrot
Copy link

Wow, that makes sense.
Mike Griese thanks for your reply! It helps me make this clear.

@henryleberre
Copy link
Author

Thanks I’ll try!

@zadjii-msft
Copy link
Member

@PolarToCartesian Did you ever figure this out?

@zadjii-msft zadjii-msft added the Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something label Jun 19, 2019
@henryleberre
Copy link
Author

Yes, sorry I forgot to report it here... I had issues with windows insider (I received updates too fast) which meant that things weren't as stable as other versions. I decided to wait for the release version!

@ghost ghost added Needs-Attention The core contributors need to come back around and look at this ASAP. Needs-Tag-Fix Doesn't match tag requirements and removed Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something labels Jun 19, 2019
@henryleberre
Copy link
Author

I just realized that the issue was due to me having transparency off in windows because of my visual handicap.

@Rob-S
Copy link

Rob-S commented May 22, 2020

In the release version, 1.0, neither backgroundTransparency / acrylicTransparency with useAcrylic set to true with a backgroundImage (tried both png and jpg) in settings.json nor the ctrl + shift + mouse wheel work for me, no matter how hard/long I scroll. The Transparency Effects is set on in Windows.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Settings Issues related to settings and customizability, for console or terminal Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Attention The core contributors need to come back around and look at this ASAP. Needs-Repro We can't figure out how to make this happen. Please help find a simplified repro. Needs-Tag-Fix Doesn't match tag requirements Product-Terminal The new Windows Terminal.
Projects
None yet
Development

No branches or pull requests

7 participants