Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cropped text in Settings UI #8749

Closed
carlos-zamora opened this issue Jan 12, 2021 · 3 comments
Closed

Cropped text in Settings UI #8749

carlos-zamora opened this issue Jan 12, 2021 · 3 comments
Labels
Area-SettingsUI Anything specific to the SUI Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Tag-Fix Doesn't match tag requirements Priority-1 A description (P1) Product-Terminal The new Windows Terminal.
Milestone
Terminal v1.6

Comments

@carlos-zamora
Copy link
Member

The following controls in the Settings UI could have text in them that, when localized, may become too long and are thus cropped:

  • Navigation view header
  • Color Scheme page...
    • add new button
    • color labels
@carlos-zamora carlos-zamora added Issue-Bug It either shouldn't be doing this or needs an investigation. Product-Terminal The new Windows Terminal. Priority-1 A description (P1) Area-SettingsUI Anything specific to the SUI labels Jan 12, 2021
@carlos-zamora carlos-zamora added this to the Terminal v1.6 milestone Jan 12, 2021
@ghost ghost added the Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting label Jan 12, 2021
@carlos-zamora
Copy link
Member Author

The color labels can be fixed using a simple redesign:

  • remove text for each color button
  • instead, add a tooltip (and automation property) that includes the label

This also allows the buttons to be smaller and the page to look sleeker.

@carlos-zamora carlos-zamora mentioned this issue Jan 12, 2021
Open
25 tasks
@zadjii-msft zadjii-msft removed the Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting label Jan 12, 2021
@carlos-zamora
Copy link
Member Author

Some examples:
Color Scheme - Button
Color Scheme - color labels

@carlos-zamora
Copy link
Member Author

Moved the color scheme stuff to #8765.

The header seems to be fine, actually.

@ghost ghost added the Needs-Tag-Fix Doesn't match tag requirements label Jan 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area-SettingsUI Anything specific to the SUI Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Tag-Fix Doesn't match tag requirements Priority-1 A description (P1) Product-Terminal The new Windows Terminal.
Projects
None yet
Milestone
Terminal v1.6
Development

No branches or pull requests
2 participants
@carlos-zamora @zadjii-msft