Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shell extension "Open Windows Terminal here" should start in current window #9098

Closed
schlamar opened this issue Feb 10, 2021 · 2 comments
Closed
Labels
Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing.

Comments

@schlamar
Copy link

With #8898 landed wt.exe can now start a terminal tab in an existing window.

I would expect that the new default for the "Open Windows Terminal here" shell extension is starting in the current window, as this is the common default for other sort of applications. For example browsers open a new tab when clicking on a HTML file in the Explorer or VS Code opens a new tab when opening a registered file extension.

However, right now the shell extension doesn't pass a window argument (https://github.com/microsoft/terminal/blob/e207236/src/cascadia/ShellExtension/OpenTerminalHere.cpp#L151) so there will be a new window.

Maybe there should be an option to control this behavior, but new tab in current window should be default.

@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Feb 10, 2021
@zadjii-msft
Copy link
Member

Thanks for the suggestion! This is actually already being tracked by another issue on our repo - please refer to #7071 for more discussion.

/dup #7071

@ghost
Copy link

ghost commented Feb 10, 2021

Hi! We've identified this issue as a duplicate of another one that already exists on this Issue Tracker. This specific instance is being closed in favor of tracking the concern over on the referenced thread. Thanks for your report!

@ghost ghost closed this as completed Feb 10, 2021
@ghost ghost added Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing. and removed Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Feb 10, 2021
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing.
Projects
None yet
Development

No branches or pull requests

2 participants