-
Notifications
You must be signed in to change notification settings - Fork 8.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cygwin doesn't handle SIGWINCH properly #9113
Comments
You know, I coulda swore we were tracking this somewhere. #4062, #1461, #7581 are related, but those are all crashes from resizing the underlying buffer, not "resizing the underlying buffer doesn't resize the Terminal". Just a question - are you doing this in WSL or git bash? I'm trying this script out with |
You know, I might have actually been thinking of #5094 |
I wouldn't have thought #5094 had anything to do with it. Unless I've misunderstood what is going on here, the script isn't resizing the window, it's just redrawing the text after it detects a resize. It works for me in both conhost and Windows Terminal when run from a WSL bash shell. I assumed the issue was something specific to Cygwin. |
Oh, maybe I'm misunderstanding what the sample was supposed to be doing. I thought it was trying to resize the terminal to some size, not listen for buffer size events. This is working perfectly fine in WSL, so I'd agree that this is probably a cygwin-specific issue and should be filed on their issue tracker. |
Marking this one external. Thanks all! |
I issued this problem to Cygwin developers and waiting for a feedback now. ;) |
SIGWINCH is unreliable, ive tested it doesnt work on fresh Debian install with gnome desktop. it should be abolished in preference to polling |
Environment
Steps to reproduce
Execute this Bash script and try resize Windows Terminal window:
As you see Windows Terminal doesn't handles SIGWINCH properly. However everything works fine when I execute my script directly from Cygwin Terminal without Windows Terminal.
Expected behavior
Centered text is drawn on the screen after window resize.
Actual behavior
Text isn't centered after window resize.
The text was updated successfully, but these errors were encountered: