Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support maximising split panes #9311

Closed
perfectlysensible opened this issue Mar 1, 2021 · 3 comments
Closed

Support maximising split panes #9311

perfectlysensible opened this issue Mar 1, 2021 · 3 comments
Labels
Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing.

Comments

@perfectlysensible
Copy link

Description of the new feature/enhancement

It would be useful to be able to toggle between the current split pane view, and a maximized view of the current pane.

Maximizing a split pane involves making the current split pane occupy the whole window. This is a useful feature in cases where the user temporarily wants a fullscreen view of the current split pane (e.g. viewing a wide log file) but later wants to use the original layout size.

Proposed technical implementation details (optional)

A user would commonly use this feature with a shortcut (e.g. ctrl-alt-m -> maximize). Typing the shortcut once would make the currently selected split pane occupy the whole window; typing it again would restore the split pane layout.

@perfectlysensible perfectlysensible added the Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. label Mar 1, 2021
@ghost ghost added Needs-Tag-Fix Doesn't match tag requirements Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting labels Mar 1, 2021
@zadjii-msft
Copy link
Member

We actually already support this feature! We call in "zooming" a pane. It was first added in #6989, in Preview v1.3. I don't think it's currently bound to a key by default, but it is in the command palette. You can add a keybinding for it with:

{ "keys": "ctrl+alt+m", "command": "togglePaneZoom" }

/dup #996

@ghost
Copy link

ghost commented Mar 1, 2021

Hi! We've identified this issue as a duplicate of another one that already exists on this Issue Tracker. This specific instance is being closed in favor of tracking the concern over on the referenced thread. Thanks for your report!

@ghost ghost closed this as completed Mar 1, 2021
@ghost ghost added Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing. and removed Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Mar 1, 2021
@perfectlysensible
Copy link
Author

Thanks @zadjii-msft, I did search for existing feature requests but apparently missed searching for existing features.

I've tried out the feature just now, it's awesome. 👍

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing.
Projects
None yet
Development

No branches or pull requests

2 participants