Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug Report - Font Ligatures interact with the shell prompt #938

Closed
tensor-programming opened this issue May 22, 2019 · 5 comments
Closed
Labels
Area-Rendering Text rendering, emoji, complex glyph & font-fallback issues Issue-Bug It either shouldn't be doing this or needs an investigation. Product-Terminal The new Windows Terminal. Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing.

Comments

@tensor-programming
Copy link

Environment

Windows 1903
Fira Code with Font Ligatures enabled

Steps to reproduce

Use a font with font ligatures and type - or = as your first character.

Expected behavior

I would expect the prompt not to interact with the characters. In c:\projects\> the > symbol should not connect with any font ligatures.

Actual behavior

The > symbol combines to create font ligatures.

The behavior is shown in the below images:
font-ligatures-error-1
font-ligatures-error-2

@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels May 22, 2019
@mdtauk
Copy link

mdtauk commented May 22, 2019

The Prompt should really be self contained. Maybe the settings screen should provide a visual way to choose your own prompt, if you wanted to use CharacterMap to insert a character, or a ligature sequence that wont combine with characters after it.

@tensor-programming
Copy link
Author

tensor-programming commented May 22, 2019

Yes, this is what I am thinking as well. Decoupling the prompt from the inputted text to allow for different options. Then maybe custom prompts would also be possible.

In WSL at least there is a space between the prompt and the input so Ligatures are not possible. However, in both powershell and cmd it seems that they are.

@HBelusca
Copy link
Contributor

Would inserting an (invisible) zero-width unicode space character after the end of the prompt fix the problem?

@tensor-programming
Copy link
Author

You could fix the problem with a break character of any kind. Ligatures are combinations of unicode characters to build symbols and they are a part of the font.

@glen-84
Copy link

glen-84 commented May 22, 2019

Duplicate of #514.

@zadjii-msft zadjii-msft added Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing. and removed Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting labels May 22, 2019
@miniksa miniksa added Area-Rendering Text rendering, emoji, complex glyph & font-fallback issues Issue-Bug It either shouldn't be doing this or needs an investigation. Product-Terminal The new Windows Terminal. labels May 29, 2019
@ghost ghost removed the Needs-Tag-Fix Doesn't match tag requirements label May 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Rendering Text rendering, emoji, complex glyph & font-fallback issues Issue-Bug It either shouldn't be doing this or needs an investigation. Product-Terminal The new Windows Terminal. Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing.
Projects
None yet
Development

No branches or pull requests

6 participants