-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Settings UI - unexpected profile sources handling and icon entry handling #9864
Comments
Alright, so painfully, there are two issues in your post, so that makes it really hard to address them. Lets try one at a time. Profile is linked somehow to inbuilt "sources"Can you share your Icon handling is confusing.This might be another case of #9775. Apparently some settings are just not applying for some profiles for some users. It's unclear exactly as to why - my theory is that something weird is going on with the dynamic profiles. Seeing your entire settings file might help identify a root cause here. |
here is my settings.json
|
Hi! We've identified this issue as a duplicate of another one that already exists on this Issue Tracker. This specific instance is being closed in favor of tracking the concern over on the referenced thread. Thanks for your report! |
Windows Terminal version (or Windows build number)
1.7.1033.0
Other Software
I run WSL1 side by side with WSL2 (WSL1 is my main and WSL2 for experimentation).
I launch WSL1 via custom profile ("wsl ~" to get me in home dir at startup and some custom titles etc). Disable the inbuilt sources:
With the line above, no auto entry for WSL1 or WSL2. (as expected)
when I comment out that line; new entry for WSL2 appears. Ok fine. But somehow, my custom profile WSL1 in settings UI becomes affected as well and settings UI says 'this cannot be deleted because automatically generated.
Not a biggie problem but very unexpected (expect seperate profile generated where all auto actions happen to that one not the one I have built)
When playing around with this one item I saw was that the inbuilt has a penguin icon (my custom had a default "C:>" icon)
This is exposed in settings UI has under icon entry "ms-appx:///ProfileIcons/{9acb9455-ca41-5af7-950f-6bca1bc9722f}.png"
I copy that exact text and (after disable auto sources) put into my custom profile.
It doesn't work (presumably coz that is some magic link generated and not an actual icon file)
The Settings UI should be consistent where text inside the icon field of auto generated profiles can be used in custom profiles.
Steps to reproduce
.
Expected Behavior
No response
Actual Behavior
.
The text was updated successfully, but these errors were encountered: